Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable add Ansible extra var list #217

Merged

Conversation

electrocucaracha
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
Ansible allows overriding the default value of roles with different methods. This change provides a method to allow the users to pass new values from bash.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: Victor Morales <v.morales@samsung.com>
@electrocucaracha
Copy link
Member Author

/retest

@electrocucaracha
Copy link
Member Author

/override e2e-ubuntu-focal
/override e2e-fedora-34

Copy link
Contributor

nephio-prow bot commented Nov 16, 2023

@electrocucaracha: Overrode contexts on behalf of electrocucaracha: e2e-fedora-34, e2e-ubuntu-focal

In response to this:

/override e2e-ubuntu-focal
/override e2e-fedora-34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@lapentad lapentad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

I think ANSIBLE_CMD_EXTRA_VAR_LIST will make the script more flexible

@radoslawc
Copy link
Collaborator

/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented Nov 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lapentad, radoslawc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Nov 18, 2023
@nephio-prow nephio-prow bot merged commit 28a4c18 into nephio-project:main Nov 18, 2023
@electrocucaracha electrocucaracha deleted the expose_k8s_context branch November 18, 2023 16:00
dkosteck pushed a commit to vjayaramrh/test-infra that referenced this pull request Aug 15, 2024
Signed-off-by: Victor Morales <v.morales@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants