Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tox linter in provision folder #190

Merged

Conversation

electrocucaracha
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
There are some linting rules which need to be applied to the e2e/provision folder every time that a new change is detected on that folder. This change provides a prow job to achive that.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
The nephio/linter:1 docker image needs to be published before merging this patch.

Does this PR introduce a user-facing change?:


Signed-off-by: Victor Morales <v.morales@samsung.com>
Signed-off-by: Victor Morales <v.morales@samsung.com>
@nephio-prow
Copy link
Contributor

nephio-prow bot commented Sep 15, 2023

@electrocucaracha: The label(s) kind/feature cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
There are some linting rules which need to be applied to the e2e/provision folder every time that a new change is detected on that folder. This change provides a prow job to achive that.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
The nephio/linter:1 docker image needs to be published before merging this patch.

Does this PR introduce a user-facing change?:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@radoslawc
Copy link
Collaborator

/approve

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Sep 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: radoslawc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Sep 19, 2023
@radoslawc
Copy link
Collaborator

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Sep 19, 2023
@nephio-prow nephio-prow bot merged commit 6847387 into nephio-project:main Sep 19, 2023
@electrocucaracha electrocucaracha deleted the enable-provision-linter branch September 26, 2023 16:20
@electrocucaracha
Copy link
Member Author

@radoslawc did you build the image and publish it on the public registry?

dkosteck pushed a commit to vjayaramrh/test-infra that referenced this pull request Aug 15, 2024
* Create nephio/tox container image

Signed-off-by: Victor Morales <v.morales@samsung.com>

* Enable provision linter in prow

Signed-off-by: Victor Morales <v.morales@samsung.com>

---------

Signed-off-by: Victor Morales <v.morales@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants