Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding license header checker, added E2E testbed creation job #19

Merged
merged 8 commits into from
Apr 26, 2023
Merged

Adding license header checker, added E2E testbed creation job #19

merged 8 commits into from
Apr 26, 2023

Conversation

radoslawc
Copy link
Collaborator

No description provided.

@nephio-prow nephio-prow bot requested a review from aravind254 April 19, 2023 13:41
@nephio-prow nephio-prow bot added the approved label Apr 19, 2023
@radoslawc radoslawc requested a review from vjayaramrh April 19, 2023 13:44
@vjayaramrh
Copy link
Collaborator

The earlier PR was for just license header checker, this PR has got other functionality introduced. It might be a good idea to put the other functionality in its own PR, Thanks

vjayaramrh
vjayaramrh suggested changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@vjayaramrh vjayaramrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The earlier PR was for just license header checker, this PR has got other functionality introduced. It might be a good idea to put the other functionality in its own PR, Thanks

@radoslawc
Copy link
Collaborator Author

/retitle Adding license header checker, added E2E testbed creation job

@radoslawc radoslawc changed the title adding license header checker Adding license header checker, added E2E testbed creation job Apr 20, 2023
@radoslawc
Copy link
Collaborator Author

The earlier PR was for just license header checker, this PR has got other functionality introduced. It might be a good idea to put the other functionality in its own PR, Thanks

Right, sorry about that, I've pushed E2E changes to my fork, that updated opened PR. Updated title.

vjayaramrh
vjayaramrh reviewed Apr 22, 2023
View reviewed changes
.prow.yaml Outdated Show resolved Hide resolved
This was referenced Apr 24, 2023
Closed
Closed
gvbalaji
gvbalaji requested changes Apr 24, 2023
View reviewed changes
e2e/provision/roles/deploy_mk8s/tasks/deploy_mk8s.yml Show resolved Hide resolved
images/e2e/Dockerfile Outdated Show resolved Hide resolved
e2e/provision/hosts.ini Outdated Show resolved Hide resolved
e2e/provision/deploy_mk8s.yaml Outdated Show resolved Hide resolved
@nephio-prow
Copy link
Contributor

nephio-prow bot commented Apr 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gvbalaji, radoslawc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vjayaramrh
Copy link
Collaborator

@radoslawc When would the PR for creating the 4 KIND clusters inside of a single VM be pushed? Thanks

@vjayaramrh
Copy link
Collaborator

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Apr 26, 2023
@nephio-prow nephio-prow bot merged commit 93133bc into nephio-project:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjayaramrh vjayaramrh vjayaramrh requested changes

@gvbalaji gvbalaji gvbalaji approved these changes

@aravind254 aravind254 Awaiting requested review from aravind254

Assignees

@vjayaramrh vjayaramrh

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radoslawc @vjayaramrh @gvbalaji