look up environment variables instead of passing as extra-args #189
Conversation
|
@vjayaramrh: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
|
/lgtm |
|
@vjayaramrh whenever you can, can you update the PR description? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: electrocucaracha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…o-project#189) * pull container images from registry given the credentials * look up environment variables instead of passing as extra-args * Update e2e/provision/playbooks/roles/bootstrap/tasks/prep-gitea.yml Co-authored-by: Victor Morales <chipahuac@hotmail.com> --------- Co-authored-by: Victor Morales <chipahuac@hotmail.com>
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR is a follow on to #182 and a)relies on environment variable look up rather than pass them as extra-args to an ansible playbook b)uses the ansible.builtin.command instead of ansible.builtin.shell that allows for ansible-lint checks to pass
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: