-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Terraform scripts to support other providers #179
Refactor Terraform scripts to support other providers #179
Conversation
@radoslawc it seems like prow is not detecting the changes on e2e folder? I'm wondering if we broke something |
@electrocucaracha: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7fcf5f7
to
3ebe6d9
Compare
/test e2e-fedora-34 |
Signed-off-by: Victor Morales <v.morales@samsung.com>
3ebe6d9
to
9797f62
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: electrocucaracha, vjayaramrh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Victor Morales <v.morales@samsung.com>
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The current Terraform implementation was not using all the default variables defined as well as it was missing the formatting. This change provides a different layout to allow the addition of more providers in the future. It also fixes the periodic prow job.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: