Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Terraform scripts to support other providers #179

Merged

Conversation

electrocucaracha
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
The current Terraform implementation was not using all the default variables defined as well as it was missing the formatting. This change provides a different layout to allow the addition of more providers in the future. It also fixes the periodic prow job.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@electrocucaracha
Copy link
Member Author

@radoslawc it seems like prow is not detecting the changes on e2e folder? I'm wondering if we broke something

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Aug 29, 2023

@electrocucaracha: The label(s) kind/cleanup cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
The current Terraform implementation was not using all the default variables defined as well as it was missing the formatting. This change provides a different layout to allow the addition of more providers in the future. It also fixes the periodic prow job.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nephio-prow nephio-prow bot requested review from radoslawc and vjayaramrh August 29, 2023 20:10
@nephio-prow nephio-prow bot added the approved label Aug 29, 2023
@electrocucaracha electrocucaracha force-pushed the refactor_terraform branch 2 times, most recently from 7fcf5f7 to 3ebe6d9 Compare August 29, 2023 21:15
@electrocucaracha
Copy link
Member Author

/test e2e-fedora-34

Signed-off-by: Victor Morales <v.morales@samsung.com>
@electrocucaracha
Copy link
Member Author

/retest

Copy link
Collaborator

@vjayaramrh vjayaramrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Aug 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: electrocucaracha, vjayaramrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [electrocucaracha,vjayaramrh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the lgtm label Aug 30, 2023
@nephio-prow nephio-prow bot merged commit 594e8b5 into nephio-project:main Aug 30, 2023
@electrocucaracha electrocucaracha deleted the refactor_terraform branch August 30, 2023 22:39
dkosteck pushed a commit to vjayaramrh/test-infra that referenced this pull request Aug 15, 2024
Signed-off-by: Victor Morales <v.morales@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants