Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vlan-interfaces.sh to indicate specific API #158

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Update vlan-interfaces.sh to indicate specific API #158

merged 1 commit into from
Jul 4, 2023

Conversation

matysiaq
Copy link
Contributor

@matysiaq matysiaq commented Jul 4, 2023

In my case, I had 2 resources which matched clusters shortcut

  • clusters.clusterregistry.k8s.io
  • clusters.cluster.x-k8s.io

If specific resource is not specified, kubectl get clusters command can return empty list, which is unexpected.

@matysiaq
Update vlan-interfaces.sh to indicate specific API
5cd5a5a 
In my case, I had 2 resources which mached `clusters` shortcut
- clusters.clusterregistry.k8s.io
- clusters.cluster.x-k8s.io

If specific resource is not specified, `kubectl get clusters` command can return empty list, which is unexpected.
@nephio-prow
Copy link
Contributor

nephio-prow bot commented Jul 4, 2023

Hi @matysiaq. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@electrocucaracha
Copy link
Member

/ok-to-test

@electrocucaracha
Copy link
Member

It seems to be working

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Jul 4, 2023
@electrocucaracha
Copy link
Member

/retest

@electrocucaracha
Copy link
Member

/lgtm

@radoslawc
Copy link
Collaborator

looks good
/approve

@nephio-prow nephio-prow bot added the approved label Jul 4, 2023
@nephio-prow
Copy link
Contributor

nephio-prow bot commented Jul 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matysiaq, radoslawc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot merged commit ebb71d6 into nephio-project:main Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radoslawc radoslawc radoslawc approved these changes

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@vjayaramrh vjayaramrh Awaiting requested review from vjayaramrh

Assignees

@electrocucaracha electrocucaracha

Labels
approved lgtm ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matysiaq @electrocucaracha @radoslawc