Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reading/writing default_swimlane in Project (#166) #167

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

psybers
Copy link
Contributor

@psybers psybers commented Dec 29, 2023

Description

Adds support for reading/writing default_swimlane in Project. Like any other property, you can read it:

print(project.default_swimlane)

or update it:

project.default_swimlane = 5
project.update()

References

Fixes #166

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

Note I did not add any tests specifically, but did add the default_swimlane property to one of the resource JSONs. As far as I can see, there are not tests to see if various parameters are returned when a GET happens. Similarly, there were not docs on reading individual attributes so I did not update those.

@coveralls
Copy link

Coverage Status

coverage: 97.964%. remained the same
when pulling 6cba46c on psybers:feature/166-support-default-swimlane
into 09bd026 on nephila:master.

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (09bd026) 96.57% compared to head (6cba46c) 96.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #167   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files           8        8           
  Lines         933      933           
  Branches       69       69           
=======================================
  Hits          901      901           
  Misses         19       19           
  Partials       13       13           
Flag Coverage Δ
unittests 96.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psybers psybers mentioned this pull request Dec 29, 2023
5 tasks
@protoroto protoroto requested a review from yakky December 29, 2023 20:06
@yakky yakky merged commit 7fe2fb4 into nephila:master Dec 30, 2023
18 checks passed
@protoroto
Copy link
Member

@psybers We've just released 1.3.0 version, thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for getting/setting default swimlane on a Project
4 participants