Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(templates): blog_meta category & tag classname (A) #711

Closed
wants to merge 4 commits into from

Conversation

wesleyboar
Copy link
Contributor

@wesleyboar wesleyboar commented Dec 7, 2022

Description

  • Build classname with automated, required, recognizable "slug" instead of empty "count".
  • Classname has blog-categories-__SLUG__.
  • Classname still has blog-categories-.

References

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

Use automated and required and recognizable "slug" instead of empty "count".
@wesleyboar wesleyboar changed the title fix(templates): blog_meta category & tag classname fix(templates): blog_meta category & tag classname (A) Dec 7, 2022
@yakky
Copy link
Member

yakky commented Apr 20, 2023

@wesleyboar thanks for detecting this, I should we should keep the classes compatible by adding the correct classes to the markup without replacing the wrong ones for at least a release cycle, to avoid breaking people relying on the existing classes

@coveralls
Copy link

Coverage Status

Coverage: 96.961%. Remained the same when pulling 2f5ff30 on wesleyboar:patch-1 into 33e455d on nephila:develop.

@wesleyboar wesleyboar changed the title fix(templates): blog_meta category & tag classname (A) bugfix/710-blog_meta-category-and-tag-classname Apr 21, 2023
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (33e455d) 94.24% compared to head (c46ca34) 94.24%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #711   +/-   ##
========================================
  Coverage    94.24%   94.24%           
========================================
  Files           26       26           
  Lines         1823     1823           
  Branches       260      260           
========================================
  Hits          1718     1718           
  Misses          53       53           
  Partials        52       52           
Flag Coverage Δ
unittests 94.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wesleyboar wesleyboar marked this pull request as ready for review April 21, 2023 21:26
@wesleyboar wesleyboar closed this Apr 21, 2023
@wesleyboar wesleyboar deleted the patch-1 branch April 21, 2023 21:31
@wesleyboar wesleyboar changed the title bugfix/710-blog_meta-category-and-tag-classname fix(templates): blog_meta category & tag classname (A) Apr 21, 2023
@wesleyboar
Copy link
Contributor Author

This PR was automatically closed when I renamed its branch to try to make a certain "check" pass.

I have opened #730 instead (it also has the change you requested).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markup of Category and Tag Links Have Incomplete Class
3 participants