feat(marksman): enable for markdown.mdx
#2740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closing since there is an actual mdx language server: mdx-js/mdx-analyzer#226 EDIT: reopening since it turns out the mdx language server does a different thing |
`marksman` works for MDX files. We don't want to `set ft=markdown`, since there exist tools that don't work for MDX, so we want to keep those separate
dundargoc
force-pushed
the
feat/marksman_mdx
branch
from
1cf402d to
43bde19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
marksmanworks for MDX files. We don't want toset ft=markdown, since there exist tools that don't work for MDX, so we want to keep .md and .mdx as separate filetypes.