fix(host): Add Buffer to global scope in sandbox (fixes #141) (#143)

neovim · Feb 18, 2020 · 37a5a6e · 37a5a6e
1 parent 289d40f
commit 37a5a6e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/packages/integration-tests/src/factory.test.ts b/packages/integration-tests/src/factory.test.ts
@@ -38,6 +38,9 @@ describe('Plugin Factory (used by host)', () => {
     expect(
       await pluginObj.handleRequest('Global', 'function', ['loaded'])
     ).toEqual(true);
+    expect(
+      await pluginObj.handleRequest('Global', 'function', ['Buffer'])
+    ).not.toEqual(undefined);
     expect(
       await pluginObj.handleRequest('Global', 'function', ['process'])
     ).not.toContain(['chdir', 'exit']);

diff --git a/packages/neovim/src/host/factory.ts b/packages/neovim/src/host/factory.ts
@@ -99,6 +99,7 @@ export interface Sandbox {
   module: NodeModule;
   require: (p: string) => any;
   console: { [key in keyof Console]?: Function };
+  Buffer: typeof Buffer;
 }
 
 function createSandbox(filename: string): Sandbox {
@@ -151,6 +152,9 @@ function createSandbox(filename: string): Sandbox {
   sandbox.process.stdout = devNull;
   sandbox.process.stderr = devNull;
 
+  // Buffer is no longer an owned property of 'global' variable in Node.js v12 (#141)
+  sandbox.Buffer = global.Buffer;
+
   return sandbox;
 }