Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: remove ui script tag neos 9 followup #3843

Merged
merged 1 commit into from
Sep 16, 2024
Merged

TASK: remove ui script tag neos 9 followup #3843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions packages/neos-ui-guest-frame/src/initializeGuestFrame.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,6 @@ export default ({globalRegistry, store}) => function * initializeGuestFrame() {
return;
}

// Load legacy node data scripts from guest frame - remove with Neos 9.0
const legacyNodeData = guestFrameWindow['@Neos.Neos.Ui:Nodes'] || {};

// Load all nodedata for nodes in the guest frame and filter duplicates
const {q} = yield backend.get();
const nodeContextPathsInGuestFrame = findAllNodesInGuestFrame().map(node => node.getAttribute('data-__neos-node-contextpath'));
Expand All @@ -83,7 +80,6 @@ export default ({globalRegistry, store}) => function * initializeGuestFrame() {

const nodes = Object.assign(
{},
legacyNodeData, // Merge legacy node data from the guest frame - remove with Neos 9.0
fullyLoadedNodesFromContent,
{
[documentInformation.metaData.documentNode]: documentInformation.metaData.documentNodeSerialization
Expand All @@ -93,9 +89,6 @@ export default ({globalRegistry, store}) => function * initializeGuestFrame() {
// Merge new nodes into the store
yield put(actions.CR.Nodes.merge(nodes));

// Remove the legacy inline scripts after initialization - remove with Neos 9.0
Array.prototype.forEach.call(guestFrameWindow.document.querySelectorAll('script[data-neos-nodedata]'), element => element.parentElement.removeChild(element));

const state = store.getState();

// Set the current document node to the one that is rendered in the guest frame which might be different from the one that is currently selected in the page tree
Expand Down
Loading