FEATURE: Level up to PHPStan 8 #3786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
changed the base branch from
9.0
to
task/adjustToNodeTypeOnNodeRemoval
mhsdesign
force-pushed
the
task/phpstanLevel8
branch
from
35d5f41 to
7169667
Compare
mhsdesign
commented
Jun 24, 2024
Comment on lines
478
to
480
| // todo ensure that https://github.com/neos/neos-ui/pull/3734 doesnt need to be refixed in Neos 9.0 | ||
| $redirectNode = $documentNode; | ||
| while (true) { |
There was a problem hiding this comment.
this code is probably broken but i didnt touch it here ... this deserves a follwup -> #3815
grebaldi
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Thanks so much for sustaining the type-safety efforts, @mhsdesign! 👍 👍 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us proper type errors when doing things on possible null values which is super important.
Following (non behaviour changing) adjustments were made:
ChangeInterface::getSubjectnot nullable (as we always callsetSubject, and simplify code not having to deal with the possible nullability here (which was also not done previously correctly for all cases)Changewithout context node. Its useless)finalfor sanity$view->setControllerContext(for out of band rendering) into amethod_existsas the method is with FLow9 not part of the interface anymoreUpdateWorkspaceInfonon nullable as its set always in the constructorUpdateNodeInfonon nullable as its set always via setter