BUGFIX: Make e2e tests run via docker again #3275
Conversation
This change is a backport from the fix in the 8.x branch
Limit the window height as it affects the behaviour of the selectbox dropdown in the tests.
| composer reinstall neos/test-nodetypes | ||
| composer reinstall neos/test-site | ||
| ./flow flow:package:rescan > /dev/null | ||
| ./flow flow:cache:flush > /dev/null | ||
There was a problem hiding this comment.
this change is different to 5d9d09c
is there a reason for this?
(and will result in a merge conflict)
There was a problem hiding this comment.
I wasn't sure why Markus did the change like he did and he didn't explain in his PR. So I just took the lines that were necessary to get it running again.
@markusguenther do you still remember?
I mean, why cache warmup when you run a command afterwards anyway and why show the config, etc.
There was a problem hiding this comment.
We had issues in the past with circle ci and then the tests failed on the package change. Just used the changes from the CI pipeline tests.
There was a problem hiding this comment.
im fine with merging as is, but when upmerging it we should ignore this change and keep 8.2 different?
There was a problem hiding this comment.
I can also adjust it to do the same. Fine for me.
What I did
Backported the fix from the 8.x branch.
Also makes the select box dropdown test run more reliable on various screen sizes.
How to verify it
Run
make test-e2e-docker