FEATURE: Decentral subscription store #5377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to run projections in a different database WITH their store to ensure exactly once delivery and that on critical error (memory error) the transaction is not committet and that the projection in the other db is not already ahead. TODO, allow to use actually wire it together via cr registry, That one projection runs in one database WITH its subscription store.
37 tasks
mhsdesign
commented
Nov 24, 2024
Comment on lines
+268
to
+269
| // TODO we cannot mark a subscriber as detached, if it belongs to another store and no one else is using that store anymore. Then it will just be ACTIVE and never found, not even by status | ||
| if (!$subscribers->contain($subscription->id)) { |
There was a problem hiding this comment.
but if the package is reinstalled, the old database entry will be found stating that it is still ACTIVE meaning that any interaction leading to a catchup active will lead to that the possibly really far behind projection will get a full update
|
superseeded by #5383 by using individual transactions per projection per event the same guarantees are met, just simpler :D |
|
We might introduce some kind of special connection interface concept thingy to declare for the cr factory and wiring that its important that the same connection is to be used. |
mhsdesign
added a commit
to mhsdesign/neos-development-collection
that referenced
this pull request
Dec 3, 2024
This reverts commit dc5ff10. We discussed that we dont want to ensure exactly once delivery for external projections. Adding transaction logic via traits for the projections increases logic there. And while with alot of effort we could bring exactly once delivery to work for most cases php could still decide to die in the small timeframe where we commit the one transaction and then the second. So there is no gurantee except when using a dedicated store: neos#5377
Merged
6 tasks
neos-bot
pushed a commit
to neos/contentgraph-doctrinedbaladapter
that referenced
this pull request
Dec 16, 2024
This reverts commit 194f387. We discussed that we dont want to ensure exactly once delivery for external projections. Adding transaction logic via traits for the projections increases logic there. And while with alot of effort we could bring exactly once delivery to work for most cases php could still decide to die in the small timeframe where we commit the one transaction and then the second. So there is no gurantee except when using a dedicated store: neos/neos-development-collection#5377
neos-bot
pushed a commit
to neos/contentgraph-postgresqladapter
that referenced
this pull request
Dec 16, 2024
This reverts commit 22eb7e4. We discussed that we dont want to ensure exactly once delivery for external projections. Adding transaction logic via traits for the projections increases logic there. And while with alot of effort we could bring exactly once delivery to work for most cases php could still decide to die in the small timeframe where we commit the one transaction and then the second. So there is no gurantee except when using a dedicated store: neos/neos-development-collection#5377
neos-bot
pushed a commit
to neos/contentrepository-core
that referenced
this pull request
Dec 16, 2024
This reverts commit 90ed483. We discussed that we dont want to ensure exactly once delivery for external projections. Adding transaction logic via traits for the projections increases logic there. And while with alot of effort we could bring exactly once delivery to work for most cases php could still decide to die in the small timeframe where we commit the one transaction and then the second. So there is no gurantee except when using a dedicated store: neos/neos-development-collection#5377
neos-bot
pushed a commit
to neos/contentrepositoryregistry
that referenced
this pull request
Dec 16, 2024
This reverts commit 4d72af1. We discussed that we dont want to ensure exactly once delivery for external projections. Adding transaction logic via traits for the projections increases logic there. And while with alot of effort we could bring exactly once delivery to work for most cases php could still decide to die in the small timeframe where we commit the one transaction and then the second. So there is no gurantee except when using a dedicated store: neos/neos-development-collection#5377
neos-bot
pushed a commit
to neos/neos
that referenced
this pull request
Dec 16, 2024
This reverts commit e581df2. We discussed that we dont want to ensure exactly once delivery for external projections. Adding transaction logic via traits for the projections increases logic there. And while with alot of effort we could bring exactly once delivery to work for most cases php could still decide to die in the small timeframe where we commit the one transaction and then the second. So there is no gurantee except when using a dedicated store: neos/neos-development-collection#5377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to run projections in a different database WITH their store to ensure exactly once delivery and that on critical error (memory error) the transaction is not committet and that the projection in the other db is not already ahead.
TODO, allow to use actually wire it together via cr registry, That one projection runs in one database WITH its subscription store.
see #5321 (comment)
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions