Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Ensure workspace roles and metadata are pruned with the CR. #5306

Merged
merged 1 commit into from
Oct 21, 2024
Merged

BUGFIX: Ensure workspace roles and metadata are pruned with the CR. #5306

merged 1 commit into from
Oct 21, 2024

Conversation

mficzel
Copy link
Member

@mficzel mficzel commented Oct 21, 2024 •
edited
Loading

The cr:prune command is moved into Neos.Neos package where it has access to the workspaceService.

This ensures that a cr:import will work even if the same cr already had a live workspace before that was pruned.

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mficzel
BUGFIX: Ensure workspace roles and metadata are pruned with the CR.
4f2ac23 
The `cr:prune` command is moved into Neos.Neos package where it has access to the workspaceService.
@mficzel mficzel requested a review from pKallert October 21, 2024 12:10
@mficzel mficzel requested a review from nezaniel October 21, 2024 12:14
@mficzel mficzel marked this pull request as ready for review October 21, 2024 12:27
skurfuerst
skurfuerst approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@skurfuerst skurfuerst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@skurfuerst skurfuerst merged commit bb3119a into neos:9.0 Oct 21, 2024
10 of 12 checks passed
@mficzel mficzel mentioned this pull request Oct 21, 2024
Merged
9 tasks
bwaidelich added a commit that referenced this pull request Oct 22, 2024
@bwaidelich
Follow-up to #5306
dca71c4
bwaidelich added a commit that referenced this pull request Oct 22, 2024
@bwaidelich
Follow-up to #5306
f05917a
@bwaidelich bwaidelich mentioned this pull request Oct 22, 2024
Merged
bwaidelich added a commit that referenced this pull request Oct 22, 2024
@bwaidelich
Merge pull request #5313 from neos/bugfix/pruneRoleAssignmentsAndWork…
f7aaa60 
…spaceMetadataWithCr-follow-up

Follow-up to #5306
mhsdesign added a commit that referenced this pull request Nov 11, 2024
@mhsdesign
TASK: Make pruneWorkspaceMetadata and pruneRoleAssignments intern…
99eb476 
…al by not exposing on the `WorkspaceService`

They were introduce in #5306 for the pruning, but this is a purely internal task and there is no need for this to be api for the Neos User.
Also, the reason is that it cannot be protected with security easily.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skurfuerst skurfuerst skurfuerst approved these changes

@pKallert pKallert Awaiting requested review from pKallert

@nezaniel nezaniel Awaiting requested review from nezaniel

Assignees
No one assigned
Labels
9.0 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mficzel @skurfuerst