!!! FEATURE: Stabilize WorkspaceName value object

[bwaidelich]

Extracted from #5146 this just improves stability of the WorkspaceName value object by

• Restricting the allowed value range to 30 lower case characters and properly enforce it
• Adding a tryFromString() constructor
• Exposing the MAX_LENGTH and use that for the corresponding database schemas
• Reuse instance for same values (flightweight)
• 100% test coverage

upgrade instructions

Possibly needs a migration (see #5202) which rewrites all events containing a workspaceName, which doesn't match the new workspaceName constraints and rewrites them with (shortend) a md5 hash of themself.

Run the migration with:

./flow migrateevents:migratepayloadtovalidworkspacenames

If the migration found some workspaceNames or baseWorkspaceNames to migrate, please run a projection replay of the workspace projection.

./flow cr:projectionreplay --projection workspace

Fixes: #5125
Related: #4726

[mhsdesign]

❤️

[mhsdesign]

I guess this does not fully solve your issue #5125, should it though or is that separate?

[bwaidelich]

I guess this does not fully solve your issue #5125, should it though or is that separate?

Yes, I think it does. Added a fixes tag

[Sebobo]

LGBR

[bwaidelich]

LGBR

I'm not sure what that means, but thanks for the +1 :)

[mhsdesign]

looks-good-by-reading i guess ^^

[dlubitz]

You might need to migrate your events with this migration:
#5202

[mhsdesign]

Btw while were hotfixing, we dont say what the attempted value was on error could be:

            throw new \InvalidArgumentException(sprintf('Invalid workspace name "%s" given.', $value), 1505826610);

[bwaidelich]

Btw while were hotfixing, we dont say what the attempted value was on error could be:

You made it again: I have a knot in my brain :D what do you mean?

Gotcha, you suggest to include the attempted workspace name in the exception message?!

[bwaidelich]

BTW: It's almost as easy to create a PR on Github as it is to put code in a comment: #5204 ;)