!!! TASK: Move workspace module to separate package #5118

ahaeslich · 2024-06-03T09:30:02Z

Tasks

Create new package named "Neos.Workspace.Ui"
Move settings
Move translations
Only minimal adjustments in controller code
Use singular for controller name
Register package in neos distribution
Create core migration to adjust existing privilege usages ❓

Upgrade instructions

Add neos/workspace-ui as dependency.

Review instructions

Checklist

Code follows the PSR-2 coding style
Tests have been created, run and adjusted as needed
The PR is created against the lowest maintained branch
Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
Reviewer - The first section explains the change briefly for change-logs
Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

Neos.Workspace.Ui/Classes/Controller/WorkspacesController.php

The change includes the code migration for existing projects

kdambekalns

Seems fine by reading…

…-workspace-package # Conflicts: # Neos.Neos/Resources/Private/Translations/de/Modules.xlf

mhsdesign · 2024-06-14T11:39:32Z

Neos.Workspace.Ui/Classes/Controller/WorkspaceController.php

@@ -502,7 +499,7 @@ public function rebaseAndRedirectAction(Node $targetNode, Workspace $targetWorks
        $this->redirect(
            'show',
            'Frontend\\Node',
-            'Neos.Neos',
+            'Neos.Workspace.Ui',


fyi here it must stay Neos.Neos but ill fix that

mhsdesign · 2024-06-16T08:52:21Z

Aaaand if we have a list for creating new packages we should also add that we need to adjust to include it in phpstan as well.

Btw did you migrate all the translation files by hand oO soooo much work :O or can weblate do this as well? xD

Sebobo · 2024-06-17T06:57:42Z

Did it by hand, while you were talking during the sprint 😉

kdambekalns · 2024-06-17T07:35:05Z

Did it by hand, while you were talking during the sprint 😉

I think it would have been enough to do it in the en files, Weblate should clean things up as needed then…

While extracting the workspace module into a separate package, the route was adjusted to `neos/management/workspace`. Relates: neos/neos-development-collection#5118

dlubitz · 2024-09-20T16:49:02Z

It seems, there are references to the moved translations, which where not updated and are not working anymore.

E.g: https://github.com/neos/neos-development-collection/blob/9.0/Neos.Media.Browser/Resources/Private/Templates/Usage/RelatedNodes.html#L127-L127

Are there any plans to find and change them?

(I fixed them in the RelatedNodes.html, but I guess there are more in other templates)

ahaeslich · 2024-09-23T11:13:33Z

Thx for finding the issue.

Are there any plans to find and change them?

It seems we have to check more views for this labels.

dlubitz · 2024-09-23T11:24:25Z

We might re-think which package owns the translations. E.g. the translation of "Workspace" should not be owned by a workspace package. As this is a general translation in Neos. Otherwise we would need to have a dependency to the workspace package in each package where we use the "Workspace" translation.

dlubitz · 2024-09-23T11:26:25Z

E.g. The Media Browser... By using the translation keys of Workspace.Ui I made the Media Browser package dependent on the Workspace UI package. Which shouldn't be.

With the introduction of explicit user assignments for workspaces neos#5146 and roles and the full evaluation of those via neos#5298 we have replaced the previously still kept 8.3 yaml security configuration for workspaces. This decision was done as for security we can no longer use flows security framework which uses aop inside the content-repository library, and also we wanted to cleanup the user <-> workspace relation ship as well as the concept of internal vs shared workspaces. Following yaml roles were removed: - `Neos.ContentRepository:Administrator` - `Neos.ContentRepository:InternalWorkspaceAccess` Following yaml targets were removed: - `Neos.Neos:PublicWorkspaceAccess` - `Neos.Neos:OtherWorkspacesAccess` - `Neos.Neos:Backend.OtherUsersPersonalWorkspaceAccess` - `Neos.Neos:Backend.PublishOwnWorkspaceContent` - `Neos.Neos:Backend.DiscardOwnWorkspaceContent` - `Neos.Workspace.Ui:Backend.PublishAllToLiveWorkspace` Note that these targets were moved to the `Neos.Workspace.Ui:Backend` package via neos#5118 in 9.0 but were removed now either way: - `Neos.Neos:Backend.Module.Management.Workspaces.ManageOwnWorkspaces` (`Neos.Workspace.Ui:Backend.Module.Management.Workspace.ManageOwnWorkspaces`) - `Neos.Neos:Backend.Module.Management.Workspaces.ManageInternalWorkspaces` (`Neos.Workspace.Ui:Backend.Module.Management.Workspace.ManageInternalWorkspaces`) - `Neos.Neos:Backend.Module.Management.Workspaces.ManageAllPrivateWorkspaces` (`Neos.Workspace.Ui:Backend.Module.Management.Workspace.ManageAllPrivateWorkspaces`)

With the introduction of explicit user assignments for workspaces neos/neos-development-collection#5146 and roles and the full evaluation of those via neos/neos-development-collection#5298 we have replaced the previously still kept 8.3 yaml security configuration for workspaces. This decision was done as for security we can no longer use flows security framework which uses aop inside the content-repository library, and also we wanted to cleanup the user <-> workspace relation ship as well as the concept of internal vs shared workspaces. Following yaml roles were removed: - `Neos.ContentRepository:Administrator` - `Neos.ContentRepository:InternalWorkspaceAccess` Following yaml targets were removed: - `Neos.Neos:PublicWorkspaceAccess` - `Neos.Neos:OtherWorkspacesAccess` - `Neos.Neos:Backend.OtherUsersPersonalWorkspaceAccess` - `Neos.Neos:Backend.PublishOwnWorkspaceContent` - `Neos.Neos:Backend.DiscardOwnWorkspaceContent` - `Neos.Workspace.Ui:Backend.PublishAllToLiveWorkspace` Note that these targets were moved to the `Neos.Workspace.Ui:Backend` package via neos/neos-development-collection#5118 in 9.0 but were removed now either way: - `Neos.Neos:Backend.Module.Management.Workspaces.ManageOwnWorkspaces` (`Neos.Workspace.Ui:Backend.Module.Management.Workspace.ManageOwnWorkspaces`) - `Neos.Neos:Backend.Module.Management.Workspaces.ManageInternalWorkspaces` (`Neos.Workspace.Ui:Backend.Module.Management.Workspace.ManageInternalWorkspaces`) - `Neos.Neos:Backend.Module.Management.Workspaces.ManageAllPrivateWorkspaces` (`Neos.Workspace.Ui:Backend.Module.Management.Workspace.ManageAllPrivateWorkspaces`)

!!! TASK: Move workspace module to separate package

acc8618

github-actions bot added the 9.0 label Jun 3, 2024

ahaeslich mentioned this pull request Jun 3, 2024

!!! TASK: Move workspace module to separate package #4665

Closed

6 tasks

bwaidelich reviewed Jun 3, 2024

View reviewed changes

Neos.Workspace.Ui/Classes/Controller/WorkspacesController.php Outdated Show resolved Hide resolved

Sebobo added 2 commits June 3, 2024 13:07

TASK: Move workspace module related translation files to new package

8f19629

TASK: Use singular name for WorkspaceController

f667110

Sebobo marked this pull request as ready for review June 3, 2024 11:21

TASK: Add readme and adjust composer.json for workspace ui package

2c1b78e

Sebobo force-pushed the feature/4255-introduce-workspace-package branch from 4d8eeb0 to 4d9ed13 Compare June 3, 2024 11:49

!!! TASK: Adjust workspace module privilege names

67c9ec4

The change includes the code migration for existing projects

Sebobo force-pushed the feature/4255-introduce-workspace-package branch from 4d9ed13 to 67c9ec4 Compare June 3, 2024 11:56

Sebobo self-requested a review June 3, 2024 11:58

ahaeslich mentioned this pull request Jun 3, 2024

TASK: Add Neos.Workspace.Ui neos/slicer#22

Merged

kdambekalns approved these changes Jun 3, 2024

View reviewed changes

ahaeslich requested a review from bwaidelich June 3, 2024 15:02

Merge remote-tracking branch 'origin/9.0' into feature/4255-introduce…

e9bb2b8

…-workspace-package # Conflicts: # Neos.Neos/Resources/Private/Translations/de/Modules.xlf

ahaeslich merged commit bc01151 into 9.0 Jun 4, 2024
10 checks passed

ahaeslich deleted the feature/4255-introduce-workspace-package branch June 4, 2024 15:10

mhsdesign reviewed Jun 14, 2024

View reviewed changes

mhsdesign mentioned this pull request Jun 18, 2024

!!! FEATURE: Extract workspace metadata and user-assignment to Neos #5146

Merged

ahaeslich mentioned this pull request Jun 28, 2024

BUGFIX: Adjust route to workspace module neos/neos-ui#3818

Merged

This was referenced Jan 6, 2025

!!! TASK: Remove obsolete legacy yaml policy for workspaces #5417

Merged

!!! Remove obsolete Neos service routes with Neos 9.0 #5423

Open

mhsdesign mentioned this pull request Jan 28, 2025

FEATURE: New workspace module (fusion & htmx) v1 #5132

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

!!! TASK: Move workspace module to separate package #5118

!!! TASK: Move workspace module to separate package #5118

ahaeslich commented Jun 3, 2024 •

edited by Sebobo

Loading

kdambekalns left a comment

mhsdesign Jun 14, 2024

mhsdesign commented Jun 16, 2024

Sebobo commented Jun 17, 2024

kdambekalns commented Jun 17, 2024

dlubitz commented Sep 20, 2024 •

edited

Loading

ahaeslich commented Sep 23, 2024

dlubitz commented Sep 23, 2024

dlubitz commented Sep 23, 2024

!!! TASK: Move workspace module to separate package #5118

!!! TASK: Move workspace module to separate package #5118

Conversation

ahaeslich commented Jun 3, 2024 • edited by Sebobo Loading

kdambekalns left a comment

Choose a reason for hiding this comment

mhsdesign Jun 14, 2024

Choose a reason for hiding this comment

mhsdesign commented Jun 16, 2024

Sebobo commented Jun 17, 2024

kdambekalns commented Jun 17, 2024

dlubitz commented Sep 20, 2024 • edited Loading

ahaeslich commented Sep 23, 2024

dlubitz commented Sep 23, 2024

dlubitz commented Sep 23, 2024

ahaeslich commented Jun 3, 2024 •

edited by Sebobo

Loading

dlubitz commented Sep 20, 2024 •

edited

Loading