!!! FEATURE: Bind ContentGraph to workspace

[kitsunet]

The ContentGraph is now always bound to a WorkspaceName and ContentStreamId combination.
The internal! ProjectionState of the ContentGraph is now the ContentGraphFinder which allows you to get an instance of the ContentGraph bound to a combination (usually by giving only the WorkspaceName).

The userland way to access the content graph is to ask the content repository:

ContentRepository::getContentGraph(WorkspaceName)

Upgrade instructions

The WorkspaceName must be passed along to get a subgraph instead of the internal ContentStreamId:

- $subgraph = $contentRepository->getContentGraph()->getSubgraph(
-     $workspace->currentContentStreamId,
-     $dimensionSpacePoint,
-     VisibilityConstraints::withoutRestrictions()
- );              
+ $subgraph = $contentRepository->getContentGraph($workspace->workspaceName)->getSubgraph(
+     $dimensionSpacePoint,
+     VisibilityConstraints::withoutRestrictions()
+ );

This pr presents an in between step. Its for example currently not easily possible to get the WorkspaceName of a Node, but that will be solved in a following pr see also #4564.
In this intermediate step, one must ask the workspace finder first to resolve a workspace for content stream which then can be passed to getContentGraph (see how ContentRepositoryRegistry::subgraphForNode handles it internally)

Review instructions

Followups: #5038
Neos Ui adjustments: neos/neos-ui#3775

[bwaidelich]

@kitsunet Thanks so much for putting a tremendous amount of time into this. I think it looks great already.
I just left some mostly nitpicky comments after a first quick pass mostly to dump my thoughts – no need to fix those (now).

One more important architectural choice is the stateful ContentGraphFinder.
If I get it right, it now needs a getInstances() method such that we can access (and reset the state of) all previously created CG instances in order to enable or disable their inMemory cache.
And then we need a reset() method to reset the instances for tests.

This is quite a lot of "burden" to an interface (and custom implementations) for some really low-level goals.
Maybe together we can come up with a slightly different mechanism to work with those runtime caches. But this is certainly no reason to block this one, we could always tweak it in a follow-up.

Great work!

[kitsunet]

@kitsunet Thanks so much for putting a tremendous amount of time into this. I think it looks great already. I just left some mostly nitpicky comments after a first quick pass mostly to dump my thoughts – no need to fix those (now).

One more important architectural choice is the stateful ContentGraphFinder. If I get it right, it now needs a getInstances() method such that we can access (and reset the state of) all previously created CG instances in order to enable or disable their inMemory cache. And then we need a reset() method to reset the instances for tests.

This is quite a lot of "burden" to an interface (and custom implementations) for some really low-level goals. Maybe together we can come up with a slightly different mechanism to work with those runtime caches. But this is certainly no reason to block this one, we could always tweak it in a follow-up.

Great work!

<3 Thank you!

Yes lets definitely have a look at those low level things, they were really an afterthought since I realized that definitely the tests do not like having the instances around. We could completely skip the cache, but then any cache within the CG or subgraph wouldn't be much use either because you get a fresh instance every time.

[bwaidelich]

@kitsunet I took the freedom to push our changes from yesterday (24cfa06) to this PR. I don't know if tests are still green because there is a conflict that I wasn't able to resolve

[kitsunet]

Hah, net minus lines, nice!

[mhsdesign]

UI Adjustments: neos/neos-ui#3775

[mhsdesign]

Wow. What a blast. As bastian had one last go through i also found some mininini things (just apply and merge :D)

Additionally i managed to get the Neos Ui e2e tests running in addition to the Neos ui adjustments i prepared.

So i consider this absolutely ready and it can be merged this evening!

[kitsunet]

Note for later:
Interesting that removal of the "doesNotExistYet" check did not lead any test to fail. Might be worth adding a test that checks that handling a command that tries to create an already existing ContentStream actually fails with the (re-added) exception.

[mhsdesign]

Wow now its finally done. Thx for the plenty adjustments and your motivation.

@bwaidelich do you want to +1 as well?

[bwaidelich]

@mhsdesign being trigger-happy again without even waiting for the checks to pass :)

[mhsdesign]

Haha lol idk this was automerge? 😂