Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Set language by dimension in fusion (for translations) #4931

Conversation

ClaraRuna
Copy link
Contributor

@ClaraRuna ClaraRuna commented Mar 11, 2024

Issue: #4930

Review instructions

From 8.3 to 9 in Neos\Neos\View\FusionView::render the function-call to Neos\Neos\View\FusionViewI18nTrait::setFallbackRuleFromDimension that sets the content dimension language got lost. This PR reinserts it.

FusionView Tests are currently marked as skipped because they have to be rewritten.

Checklist

There is no concept for testing Fusion views so far, but the fix was tested manually by the author

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@github-actions github-actions bot added the 9.0 label Mar 11, 2024
Copy link
Member

@kitsunet kitsunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, that seens easier than I feared it might be :)

@ClaraRuna
Copy link
Contributor Author

The difficult part is actually writing the tests ^^

@ahaeslich ahaeslich changed the title DRAFT: BUGFIX: Evaluate language dimension when rendering nodes. BUGFIX: Evaluate language dimension when rendering nodes. Mar 13, 2024
@github-actions github-actions bot added the Bug label Mar 13, 2024
@ahaeslich
Copy link
Member

The difficult part is actually writing the tests ^^

@ClaraRuna will the tests be part of this PR?

@ahaeslich ahaeslich linked an issue Mar 13, 2024 that may be closed by this pull request
1 task
@ClaraRuna
Copy link
Contributor Author

I'd suggest merging it as it is. @mhsdesign and some others discussed the topic of writing beehat tests for fusion views, but it seems to be a topic that will still beed some time.

Copy link
Contributor

@dlubitz dlubitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks pretty straight forward.

@dlubitz dlubitz merged commit 18046a6 into neos:9.0 Mar 13, 2024
11 checks passed
@mhsdesign mhsdesign changed the title BUGFIX: Evaluate language dimension when rendering nodes. BUGFIX: Set language by dimension in fusion (for translations) Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Fusion translations not working in Neos 9
4 participants