TASK: Workspace aware commands events migration #4890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
force-pushed
the
task/workspaceAwareCommands-events-migration
branch
from
0f02c3c to
610b512
Compare
mhsdesign
changed the title
mhsdesign
force-pushed
the
task/workspaceAwareCommands-events-migration
branch
2 times, most recently
from
7cae7fd to
0266e11
Compare
6 tasks
ahaeslich
reviewed
Mar 14, 2024
Neos.ContentRepositoryRegistry/Classes/Command/MigrateEventsCommandController.php
Outdated
Show resolved
Hide resolved
mhsdesign
force-pushed
the
task/workspaceAwareCommands-events-migration
branch
from
b62d1d4 to
e56ad74
Compare
…tmetadata` As the previous approach lead to a lot of dummy workspace names we will just reduce the complexity and ONLY write dummy workspace names as they are redundant either way
… id in workspace name
mhsdesign
force-pushed
the
task/workspaceAwareCommands-events-migration
branch
from
e56ad74 to
25e0d3b
Compare
ahaeslich
requested changes
Mar 14, 2024
There was a problem hiding this comment.
Tested it locally and run into this error while replaying the contentStream projection:
Undefined array key "workspaceName" in /application/Packages/Neos/Neos.ContentRepository.Core/Classes/Feature/WorkspacePublication/Dto/NodeIdToPublishOrDiscard.php line 46
ahaeslich
approved these changes
Mar 14, 2024
|
@ahaeslich looks perfect thanks, we will merge this tomorrow once we have @bwaidelich conceptional approval. |
bwaidelich
reviewed
Mar 14, 2024
Neos.ContentRepository.Core/Classes/Feature/Common/ContentStreamIdOverride.php
Outdated
Show resolved
Hide resolved
Neos.ContentRepository.Core/Classes/Feature/Common/ContentStreamIdOverride.php
Outdated
Show resolved
Hide resolved
Neos.ContentRepository.Core/Classes/Feature/Common/ContentStreamIdOverride.php
Outdated
Show resolved
Hide resolved
Neos.ContentRepositoryRegistry/Classes/Service/EventMigrationService.php
Outdated
Show resolved
Hide resolved
|
For documenation: replaying all projects now worked on the projects database. |
bwaidelich
reviewed
Mar 15, 2024
Neos.ContentRepository.Core/Classes/Feature/Common/ContentStreamIdOverride.php
Outdated
Show resolved
Hide resolved
ahaeslich
force-pushed
the
task/workspaceAwareCommands-events-migration
branch
from
33524f4 to
416017a
Compare
- Update Neos.ContentRepository.Core/Classes/Feature/Common/ContentStreamIdOverride.php - Update Neos.ContentRepositoryRegistry/Classes/Service/EventMigrationService.php Co-authored-by: Bastian Waidelich <b.waidelich@wwwision.de>
ahaeslich
force-pushed
the
task/workspaceAwareCommands-events-migration
branch
from
416017a to
8cd2f1d
Compare
ahaeslich
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4708