TASK: PhpStan level 1 for Neos 8.3 #4842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
force-pushed
the
task/phpStan83
branch
from
2b82a2c to
1ef2c6d
Compare
mhsdesign
changed the title
mhsdesign
requested review from
bwaidelich,
kitsunet,
mficzel,
nezaniel and
dlubitz
mhsdesign
commented
Jan 24, 2024
| @@ -597,7 +597,7 @@ public function getGroupedOpcodes($context = 3) | |||
| ]; | |||
| } | |||
|
|
|||
| if (!empty($group) && !(count($group) == 1 && $group[0][0] == 'equal')) { | |||
| if (!(count($group) == 1 && $group[0][0] == 'equal')) { | |||
There was a problem hiding this comment.
this is a bit tricky but phpstan was really stubborn that this check is obsolete and it 100% is.
$group is never empty because it is filled in the foreach above where the variable $opCodes always have at least one entry.
| @@ -922,6 +922,7 @@ public function getProperty($propertyName, bool $returnNodesAsIdentifiers = fals | |||
| } | |||
|
|
|||
| if ( | |||
| /** @phpstan-ignore-next-line i will not touch this code */ | |||
There was a problem hiding this comment.
The old Node::getProperty does uuuuuglly things :D And i dont want to appear in its git blame :D
| @@ -168,6 +168,7 @@ public function setOptions($options) | |||
| */ | |||
| public static function createByConfiguration($modeName, array $configuration) | |||
| { | |||
| /** @phpstan-ignore-next-line */ | |||
There was a problem hiding this comment.
the user interface mode will be refactored either way with neos 9 ^^
| @@ -110,6 +110,7 @@ public function processRequest(ActionRequest $request, ActionResponse $response) | |||
| */ | |||
| protected function convertException(\Exception $exception) | |||
| { | |||
| $exceptionData = []; | |||
There was a problem hiding this comment.
line 146 could in a very unlikely case throw an Error because the variable is not initialised.
Also line 116 makes use of phps implicit variable array initialisation which is unexpected ^^
mhsdesign
commented
Jan 24, 2024
mhsdesign
force-pushed
the
task/phpStan83
branch
from
89bd03f to
ee2ab6e
Compare
dlubitz
approved these changes
Feb 2, 2024
Neos.Media/Classes/Domain/Model/AssetSource/Neos/NeosAssetProxyQueryResult.php
Outdated
Show resolved
Hide resolved
mhsdesign
force-pushed
the
task/phpStan83
branch
from
ee2ab6e to
5651c01
Compare
mhsdesign
force-pushed
the
task/phpStan83
branch
from
5651c01 to
6b338b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds phpstan to the Neos 8.3 branch to all packages with a minimal level 1:
Errors caused by the back-port of the ESCR TraversableNodeInterface, have been directly ignored via
ignoreErrors.Other actually fixable errors have been fixed in a non breaking way. (Adjusting the doc types e.g.)
This should provide a little starting base for extending php stan level across all packages to higher levels in the upcoming 9.0 branch, where we actually use phpstan at level 8 for the following packages:
As
Neos.Fusiondidnt need to be adjusted for neos 9 i started to migrate this package to level 8 for neos 8.3 already to avoid too many upmerge conflicts:#4844
More packages, if applicable, will follow.
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions