BUGFIX: Skip node data processing for invalid properties #4807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can happen that node properties are not available in a new version of the package. But when the properties are still part of the neos_contentrepository_domain_model_nodedata table, the migration tries to process the data for a node and throws an exception as the node property is not available in the node type schema anymore. To prevent that exceptions in the legacy data migration, we skip the procession for such properties and output a warning for the user. Fixes: neos#4804
bwaidelich
reviewed
Dec 17, 2023
Neos.ContentRepository.LegacyNodeMigration/Classes/NodeDataToAssetsProcessor.php
Show resolved
Hide resolved
Neos.ContentRepository.LegacyNodeMigration/Classes/NodeDataToEventsProcessor.php
Show resolved
Hide resolved
|
Looking good, I'll try to add some tests |
bwaidelich
approved these changes
Dec 18, 2023
ahaeslich
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can happen that node properties are not available in a new version of the package. But when the properties are still part of the neos_contentrepository_domain_model_nodedata table, the migration tries to process the data for a node and throws an exception as the node property is not available in the node type schema anymore.
To prevent that exceptions in the legacy data migration, we skip the procession for such properties and output a warning for the user.
Fixes: #4804
Review instructions
As it is described in the linked issue, the twitter related properties in the Neos-Seo package have been removed in the latest version for Neos 9. When you upgrade your project from Neos 8.3 to Neos 9.0 you will increase the package version as well, but the data is still part of your database. To be able to test it, you can install a Neos 8.3 instance and change a Twitter Card property in the backend and publish that. When you now upgrade the Neos to version 9.0 and execute
./flow cr:migrateLegacyDataYou should see something like that instead of an exception.Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions