Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Extends exception message with NodeType name #4806

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

markusguenther
Copy link
Member

@markusguenther markusguenther commented Dec 15, 2023

When the NodeType property name is not available for the given NodeType we throw an exception. The exception method only mentions the property name, and that can be irritating when you have multiple NodeTypes with that property name or multiple errors. So this change extends the error message with the current NodeType name.

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

When the NodeType property name is not available for the given NodeType we throw an exception. The exception method only mentions the property name, and that can be irritating when you have multiple NodeTypes with that property name or multiple errors. So this change extends the error message with the current NodeType name.
@markusguenther
Copy link
Member Author

markusguenther commented Dec 15, 2023

As an example, we could take the current legacy Migration:
Screenshot 2023-12-15 at 17 28 44

PR to prevent such messages will follow.

@ahaeslich ahaeslich merged commit 1f54e1b into neos:9.0 Dec 20, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants