-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: Add phpstan to all Neos.ContentRepository*
packages
#4650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neos.ContentRepository.Export
bwaidelich
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet summer child!
This is considered a temporary solution, which was also broken.
Neos.ContentRepository*
packages
kitsunet
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems fine to me.
mhsdesign
added a commit
to mhsdesign/neos-development-collection
that referenced
this pull request
Feb 13, 2024
During extending phpstan to more packages (neos#4650) the migration was dropped. The code had become already outdated by then as the api was changed a lot. This service should function as boilerplate for new migrations.
mhsdesign
added a commit
that referenced
this pull request
Feb 14, 2024
During extending phpstan to more packages (#4650) the migration was dropped. The code had become already outdated by then as the api was changed a lot. This service should function as boilerplate for new migrations.
mhsdesign
added a commit
that referenced
this pull request
Feb 19, 2024
During extending phpstan to more packages (#4650) the migration was dropped. The code had become already outdated by then as the api was changed a lot. This service should function as boilerplate for new migrations.
mhsdesign
added a commit
that referenced
this pull request
Feb 22, 2024
During extending phpstan to more packages (#4650) the migration was dropped. The code had become already outdated by then as the api was changed a lot. This service should function as boilerplate for new migrations.
mhsdesign
added a commit
that referenced
this pull request
Feb 23, 2024
During extending phpstan to more packages (#4650) the migration was dropped. The code had become already outdated by then as the api was changed a lot. This service should function as boilerplate for new migrations.
neos-bot
pushed a commit
to neos/contentrepositoryregistry
that referenced
this pull request
Feb 26, 2024
During extending phpstan to more packages (neos/neos-development-collection#4650) the migration was dropped. The code had become already outdated by then as the api was changed a lot. This service should function as boilerplate for new migrations.
mhsdesign
added a commit
to mhsdesign/neos-development-collection
that referenced
this pull request
Mar 13, 2024
During extending phpstan to more packages (neos#4650) the migration was dropped. The code had become already outdated by then as the api was changed a lot. This service should function as boilerplate for new migrations. WIP: Try to fix previous `EventMigrationService` After neos#4405 a lot of things changed. WIP: Write migration for workspace rename untested.
mhsdesign
added a commit
to mhsdesign/neos-development-collection
that referenced
this pull request
Mar 14, 2024
During extending phpstan to more packages (neos#4650) the migration was dropped. The code had become already outdated by then as the api was changed a lot. This service should function as boilerplate for new migrations. WIP: Try to fix previous `EventMigrationService` After neos#4405 a lot of things changed. WIP: Write migration for workspace rename untested.
mhsdesign
added a commit
to mhsdesign/neos-development-collection
that referenced
this pull request
Mar 14, 2024
During extending phpstan to more packages (neos#4650) the migration was dropped. The code had become already outdated by then as the api was changed a lot. This service should function as boilerplate for new migrations. WIP: Try to fix previous `EventMigrationService` After neos#4405 a lot of things changed. WIP: Write migration for workspace rename untested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those packages are now also green and running in ci:
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions