Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Add phpstan to all Neos.ContentRepository* packages #4650

Merged
merged 10 commits into from
Nov 2, 2023

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Oct 29, 2023

Those packages are now also green and running in ci:

  • Neos.ContentRepository.Export
  • Neos.ContentRepository.LegacyNodeMigration
  • Neos.ContentRepository.NodeAccess
  • Neos.ContentRepository.StructureAdjustment
  • Neos.ContentRepositoryRegistry

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign changed the title TASK: Fix types from Neos.ContentRepository.Export Was ist besser als phpstan in der bahn? Oct 29, 2023
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet summer child!

@mficzel mficzel marked this pull request as draft October 30, 2023 10:10
@mhsdesign mhsdesign marked this pull request as ready for review November 1, 2023 11:37
@mhsdesign mhsdesign changed the title Was ist besser als phpstan in der bahn? TASK: Add phpstan to all Neos.ContentRepository* packages Nov 1, 2023
Copy link
Member

@kitsunet kitsunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me.

@mhsdesign mhsdesign merged commit 2b878a4 into 9.0 Nov 2, 2023
@mhsdesign mhsdesign deleted the task/phpstanInDerBahn branch November 2, 2023 19:04
mhsdesign added a commit to mhsdesign/neos-development-collection that referenced this pull request Feb 13, 2024
During extending phpstan to more packages (neos#4650) the migration was dropped.
The code had become already outdated by then as the api was changed a lot.
This service should function as boilerplate for new migrations.
mhsdesign added a commit that referenced this pull request Feb 14, 2024
During extending phpstan to more packages (#4650) the migration was dropped.
The code had become already outdated by then as the api was changed a lot.
This service should function as boilerplate for new migrations.
mhsdesign added a commit that referenced this pull request Feb 19, 2024
During extending phpstan to more packages (#4650) the migration was dropped.
The code had become already outdated by then as the api was changed a lot.
This service should function as boilerplate for new migrations.
mhsdesign added a commit that referenced this pull request Feb 22, 2024
During extending phpstan to more packages (#4650) the migration was dropped.
The code had become already outdated by then as the api was changed a lot.
This service should function as boilerplate for new migrations.
mhsdesign added a commit that referenced this pull request Feb 23, 2024
During extending phpstan to more packages (#4650) the migration was dropped.
The code had become already outdated by then as the api was changed a lot.
This service should function as boilerplate for new migrations.
neos-bot pushed a commit to neos/contentrepositoryregistry that referenced this pull request Feb 26, 2024
During extending phpstan to more packages (neos/neos-development-collection#4650) the migration was dropped.
The code had become already outdated by then as the api was changed a lot.
This service should function as boilerplate for new migrations.
mhsdesign added a commit to mhsdesign/neos-development-collection that referenced this pull request Mar 13, 2024
During extending phpstan to more packages (neos#4650) the migration was dropped.
The code had become already outdated by then as the api was changed a lot.
This service should function as boilerplate for new migrations.

WIP: Try to fix previous `EventMigrationService`

After neos#4405 a lot of things changed.

WIP: Write migration for workspace rename

untested.
mhsdesign added a commit to mhsdesign/neos-development-collection that referenced this pull request Mar 14, 2024
During extending phpstan to more packages (neos#4650) the migration was dropped.
The code had become already outdated by then as the api was changed a lot.
This service should function as boilerplate for new migrations.

WIP: Try to fix previous `EventMigrationService`

After neos#4405 a lot of things changed.

WIP: Write migration for workspace rename

untested.
mhsdesign added a commit to mhsdesign/neos-development-collection that referenced this pull request Mar 14, 2024
During extending phpstan to more packages (neos#4650) the migration was dropped.
The code had become already outdated by then as the api was changed a lot.
This service should function as boilerplate for new migrations.

WIP: Try to fix previous `EventMigrationService`

After neos#4405 a lot of things changed.

WIP: Write migration for workspace rename

untested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants