-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
!!! FEATURE: Neos.Neos:Site
NodeType
#4563
Conversation
… of type `Neos.Neos:Site`.
Makes sense I guess. I am sure though there will be many sites out there that do not have an explicit homepage nodetype right now and need structure adjustments for this. Do we / can we prepare one for this? Or a command ala |
|
About an upgrade guide for people without dedicated page node i have created this task: #5400 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the mix up of public constant and static method usage. Would be more clear if there were just one way of getting the nodeTypeName values. Even if it's more complex to get it in cases where you simply need the string value. But this is the price of type safetiness, isn't it?
Neos.ContentRepository.LegacyNodeMigration/Classes/NodeDataToEventsProcessor.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Denny Lubitz <lubitz@vivomedia.de>
i thought so too at first, but after seeing But either way lets discuss this in a dedicated issue to not block this pr :D |
6ae9c3c
to
b2cd87c
Compare
I resolved merge conflicts and tested this locally with the neos demo (adjustment neos/Neos.Demo#182) and the neos ui (adjustment neos/neos-ui#3629) the neos ui e2e test succeed locally. |
The rather hacky method `findCurrentSiteNode` was refactored and its usage adjusted.
much has changed since the start ;)
Looks nice, I'll add the document uri path projection adjustments in a later pr |
need re-review due to further adjustments ;)
Relates: neos#4563 Relates: neos/neos-development-collection#4567
Relates: neos/neos-development-collection#4563 Relates: neos/neos-development-collection#4567
resolves: #4531
Upgrade instructions
Your homepage must extend
Neos.Neos:Site
For more upgrade information see #5400
Review instructions
Todo actually use the
Neos.Neos:Site
in the php code when querying.Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions