Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Remove Neos.ContentRepository.Security #4544

Merged
merged 5 commits into from
Sep 29, 2023
Merged

TASK: Remove Neos.ContentRepository.Security #4544

merged 5 commits into from
Sep 29, 2023

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Sep 20, 2023 •
edited
Loading

reverts the WIP implementation for security introduced with: 2ce2b4f

see #3732

also related neos/flow-development-collection#3169 as i was able to remove the dependency to the @Isolated trait

The (global) Policy.yaml-approach does not work out for the ESCR

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign added the 9.0 label Sep 20, 2023
@github-actions github-actions bot added the Task label Sep 20, 2023
@mhsdesign mhsdesign mentioned this pull request Sep 23, 2023
Open
7 tasks
@mhsdesign
Copy link
Member Author

Some things are also implemented by @nezaniel in https://github.com/neos/neos-development-collection/tree/testSuiteRefactoring testSuiteRefactoring

@mhsdesign mhsdesign mentioned this pull request Sep 22, 2023
Open
5 tasks
@mhsdesign mhsdesign changed the title TASK: Revert WIP approach Neos.ContentRepository.Security TASK: Remove Neos.ContentRepository.Security Sep 24, 2023
@mhsdesign mhsdesign mentioned this pull request Sep 28, 2023
Closed
9 tasks
bwaidelich
bwaidelich approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 as discussed. Thanks for taking care!

@mhsdesign mhsdesign merged commit bdeb74b into 9.0 Sep 29, 2023
@mhsdesign mhsdesign deleted the task/removeWipNeos-contentrepository-securit branch September 29, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwaidelich bwaidelich bwaidelich approved these changes

@skurfuerst skurfuerst Awaiting requested review from skurfuerst

@ahaeslich ahaeslich Awaiting requested review from ahaeslich

@dlubitz dlubitz Awaiting requested review from dlubitz

@nezaniel nezaniel Awaiting requested review from nezaniel

Assignees
No one assigned
Labels
9.0beta1 9.0 Task
Projects
Neos 9.0 Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhsdesign @bwaidelich