Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Cleanup & fix workspace cli commands #4465

Merged
merged 9 commits into from
Sep 11, 2023
Merged

TASK: Cleanup & fix workspace cli commands #4465

merged 9 commits into from
Sep 11, 2023

Conversation

ahaeslich
Copy link
Member

@ahaeslich ahaeslich commented Sep 1, 2023 •
edited
Loading

  • Move command workspace:rebaseOutdated to Neos\Neos\Command\WorkspaceCommandController
  • Remove outdated command workspace:rebase
  • Fix value objects in workspace:list command
  • Add additional information to workspace:list command
  • Cleanup php doc in WorkspaceCommandController
  • Fix createCommand for workspace owner
  • Remove unsupported cli options in WorkspaceCommandController

Relates: #4186
Issue for workspace:delete: #4497

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@github-actions github-actions bot added the 9.0 label Sep 1, 2023
@ahaeslich ahaeslich mentioned this pull request Sep 11, 2023
Closed
1 task
@ahaeslich ahaeslich marked this pull request as ready for review September 11, 2023 06:30
@ahaeslich ahaeslich changed the title DRAFT: Cleanup & fix workspace cli commands TASK: Cleanup & fix workspace cli commands Sep 11, 2023
@github-actions github-actions bot added the Task label Sep 11, 2023
@ahaeslich
Copy link
Member Author

I've desided to split this cleanup form #4497 so all those other commands, that should work already can be used again.

@crydotsnake crydotsnake self-requested a review September 11, 2023 06:38
mhsdesign
mhsdesign approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

@mhsdesign mhsdesign merged commit 8cb03d5 into 9.0 Sep 11, 2023
@mhsdesign mhsdesign deleted the 90-workspace-command-controller branch September 11, 2023 08:15
@crydotsnake crydotsnake removed their request for review September 11, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlubitz dlubitz dlubitz approved these changes

@mhsdesign mhsdesign mhsdesign approved these changes

Assignees
No one assigned
Labels
9.0 Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahaeslich @dlubitz @mhsdesign