Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Fix MySQL migration differences on fresh setup #4236

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

kdambekalns
Copy link
Member

@kdambekalns kdambekalns commented Apr 30, 2023

This eliminates some differences in the actual vs the expected DB setup in a fresh
Neos 8.3 installation.

Fixes #3118 (at least partly.)

Review instructions

doctrine:migrationgenerate should just say No changes detected after Neos has been set up.

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign
Copy link
Member

Hu i must have lost track of this :D Should we still target 7.3 (last bugfix) or rather 8.3 to be safe?

@mhsdesign mhsdesign changed the base branch from 7.3 to 8.3 February 8, 2024 13:01
@github-actions github-actions bot added 8.3 and removed 7.3 labels Feb 8, 2024
@mhsdesign
Copy link
Member

I changed the base branch once, but could you please rebase on 8.3 and check if the pr is still correct ^^

@mhsdesign mhsdesign removed their request for review May 3, 2024 07:50
@kdambekalns
Copy link
Member Author

Will check…

@kdambekalns kdambekalns force-pushed the task/add-missing-migrations branch from 9edfda4 to 674d0e2 Compare May 14, 2024 09:41
@kdambekalns
Copy link
Member Author

With 8.3 this now gives me:

beach@95d7d5a35363:/application$ ./flow doctrine:migrationgenerate
No changes detected

@kdambekalns kdambekalns requested a review from mhsdesign May 14, 2024 09:42
@Sebobo
Copy link
Member

Sebobo commented Jan 20, 2025

Thx, did you check if Postgres is also affected?

@kdambekalns
Copy link
Member Author

If only I could remember. Maybe? It probably needs to be updated yet again, anyway…

@dlubitz
Copy link
Contributor

dlubitz commented Jan 20, 2025

Current output with new Neos 8.3 is:

        $this->addSql('ALTER TABLE neos_contentrepository_domain_model_nodedata DROP INDEX IDX_CE6515692D45FE4D, ADD UNIQUE INDEX UNIQ_CE6515692D45FE4D (movedto)');
        $this->addSql('ALTER TABLE neos_media_domain_model_tag DROP FOREIGN KEY FK_CA4889693D8E604F');
        $this->addSql('ALTER TABLE neos_media_domain_model_tag ADD CONSTRAINT FK_CA4889693D8E604F FOREIGN KEY (parent) REFERENCES neos_media_domain_model_tag (persistence_object_identifier) ON DELETE SET NULL');

And after appling this PR:

./flow doctrine:migrationgenerate
No changes detected

@dlubitz
Copy link
Contributor

dlubitz commented Jan 20, 2025

@Sebobo Can we merge this anyways? If there are postgress issues we can handle that also in a dedicated PR.

This is open for almost two years now and I'd like to merge it to improve the mysql usage experience.

@Sebobo
Copy link
Member

Sebobo commented Jan 20, 2025

Yes sure, I mean the title also says mysql

@dlubitz dlubitz merged commit 4cea007 into neos:8.3 Jan 20, 2025
8 checks passed
mhsdesign added a commit to mhsdesign/neos-development-collection that referenced this pull request Jan 29, 2025
the package Neos.ContentRepository does not exist in Neos 9

In neos#4240 we removed all ContentRepository migrations so this is to be removed as well.
mhsdesign added a commit that referenced this pull request Jan 29, 2025
…rged-migration

TASK: Followup #4236 remove legacy core migration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants