Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX make pagination work with Traversable #3891

Closed
wants to merge 5 commits into from
Closed

Conversation

ru3fu5z
Copy link
Contributor

@ru3fu5z ru3fu5z commented Sep 16, 2022

Related #1112

Warning: array_slice() expects parameter 1 to be array, object given in /tmp/Flow/Development/SubContextddev/Cache/Code/Flow_Object_Classes/Neos_ContentRepository_ViewHelpers_Widget_Controller_PaginateController.php line 124

Warning: array_slice() expects parameter 1 to be array, object given in /tmp/Flow/Development/SubContextddev/Cache/Code/Flow_Object_Classes/Neos_ContentRepository_ViewHelpers_Widget_Controller_PaginateController.php line 124
@ru3fu5z ru3fu5z requested a review from mhsdesign October 17, 2022 11:13
@jonnitto
Copy link
Member

@mhsdesign Do you think 8.2 is the correct branch?

@mhsdesign
Copy link
Member

Nope should be 7.3 - im not a fluid gui - but id like to see a test maybe ^^

@mhsdesign mhsdesign removed their request for review November 11, 2022 18:21
@ru3fu5z ru3fu5z changed the base branch from 8.2 to 7.3 November 15, 2022 10:17
Copy link
Member

@jonnitto jonnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ru3fu5z, thank you for your PR. I think the best is, to close this PR and create a new one, based on the correct branch.

@mhsdesign mhsdesign changed the base branch from 7.3 to 8.2 February 23, 2023 13:14
@ru3fu5z ru3fu5z closed this Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants