!!! FEATURE: Remove legacy cache tag support #3639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently checking if I can provide a core migration for those old tags. |
|
Would love to get this into 8, how can i help? |
|
Yes, will quickly do it. |
With this change Neos stops flushing old style cache tags used in Neos < 4.1. To prevent issues with caches that are not updated, all content cache tags in Fusion should be defined with the `Neos.Caching` Eel helper which exists since Neos 4.1.
markusguenther
approved these changes
Mar 23, 2022
|
Hm I rebased and force pushed, but nothing is happening... |
Sebobo
force-pushed
the
feature/remove-legacy-cache-tag-support
branch
from
38ba59e to
cc845a4
Compare
|
Another amend and force pushed fixed it. Now only the new commits are visible. |
kdambekalns
approved these changes
Mar 23, 2022
|
Ah, I see…
|
mhsdesign
reviewed
Mar 23, 2022
|
Try to trigger the check… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
In Neos 4.1 new Eel helpers were introduced to generate content cache tags in Fusion. Those make sure that the cache tags provided by the integrator are valid.
Until Neos 4.0 they needed to be written manually as string which was error prone.
But to support old cache tags that were lacking the workspace context the
ContentCacheFlusherstill cleared them.This change removes that support. So this is breaking and projects need to be adjusted when upgrading and still using those old cache tags.
The advantage of removing them is that the number of cache tags to be flushed during publishing is lower. TODO: Add number.
This change requires #3631 to be merged first.
How I did it
Removed the legacy cache tag generation.
The change also include a new code migration version
20220318111600to replace the most commonly used legacy cache tags with matching eel helper calls: