-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Custom Route for node preview #2654
FEATURE: Custom Route for node preview #2654
Conversation
..so that request patterns looking at the URL match it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you pls rebase this PR to the lastest master. The page tree does not work with it in the current state. FYI: the page tree works in the current master
@davidspiola I merged the current master branch into my fork. If you test this, make sure to flush caches (also browser caches to remove session cookie) and to apply neos/neos-ui#2545 |
@davidspiola (and all) can you please test again now? It was the Neos.UI change that needed rebasing. I got confused so I created a new PR against master: neos/neos-ui#2604 |
will do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like charm 🎉
Introduces a new Route
/neos/preview
that will be used for previewing/editing purposes in the content iFrame and to preview content that is not live or visible (yet).Advantages
Greatly reduced amount of routing cache entries
Previously, URLs for nodes in the backend had the format
<the/node/url/path>@<workspace-name>;<dimensions>
Thus leading to two routing cache entries (match & resolve) for each user, node & dimension combination.
With this change, there is only one route for those cases usinq query parameters to specify the node & context:
/neos/preview?node=<the/node/url/path>@<workspace-name>;<dimensions>
Explicit preview action
With a custom action just for the preview scenario, we can remove a lot of special magic (like displaying hidden nodes, shortcut handling, ...) from the regular frontend rendering path
Faster backend navigation
Previously all links in the Backend triggered a
redirect
route, effectively resulting in two requests.Basis for further improvements and simplifications
With a different route (and action) we could greatly simplify the code of the
FrontendRoutePartHandler
and make way for new features like partial matching (#780), multi-format-support (#870) dedicated workspace previews, ...Note: This requires neos/neos-ui#2604 to work as expected
Resolves: #2653