TASK: Apply suggestions from review

neos · Dec 10, 2024 · 5cc7e0f · 5cc7e0f
1 parent 31473fb
commit 5cc7e0f
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/Neos.ContentRepository.Core/Classes/SharedModel/Exception/WorkspaceDoesNotExist.php b/Neos.ContentRepository.Core/Classes/SharedModel/Exception/WorkspaceDoesNotExist.php
@@ -20,7 +20,7 @@
 /**
  * @api because exception is thrown during invariant checks on command execution or when attempting to query a non-existing workspace
  */
-final class WorkspaceDoesNotExist extends \RuntimeException
+final class WorkspaceDoesNotExist extends \DomainException
 {
     public static function butWasSupposedTo(WorkspaceName $name): self
     {

diff --git a/Neos.Neos/Classes/Domain/Model/WorkspaceRoleAssignments.php b/Neos.Neos/Classes/Domain/Model/WorkspaceRoleAssignments.php
@@ -107,7 +107,7 @@ public function contains(WorkspaceRoleAssignment $assignment): bool
         return false;
     }
 
-    public function add(WorkspaceRoleAssignment $assignment): self
+    public function withAssignment(WorkspaceRoleAssignment $assignment): self
     {
         return new self(...[...$this->assignments, $assignment]);
     }

diff --git a/Neos.Neos/Classes/Domain/Service/WorkspaceService.php b/Neos.Neos/Classes/Domain/Service/WorkspaceService.php
@@ -103,7 +103,7 @@ public function getPersonalWorkspaceForUser(ContentRepositoryId $contentReposito
     {
         $workspaceName = $this->metadataAndRoleRepository->findPrimaryWorkspaceNameForUser($contentRepositoryId, $userId);
         if ($workspaceName === null) {
-            throw new \RuntimeException(sprintf('No workspace is assigned to the user with id "%s")', $userId->value), 1733755300);
+            throw new \RuntimeException(sprintf('No workspace is assigned to the user with id "%s")', $userId->value), 1718293801);
         }
         return $this->requireWorkspace($contentRepositoryId, $workspaceName);
     }

diff --git a/Neos.Neos/Tests/Behavior/Features/Bootstrap/WorkspaceServiceTrait.php b/Neos.Neos/Tests/Behavior/Features/Bootstrap/WorkspaceServiceTrait.php
@@ -153,7 +153,7 @@ public function theSharedWorkspaceIsCreatedWithTheTargetWorkspace(string $worksp
     {
         $workspaceRoleAssignments = WorkspaceRoleAssignments::createEmpty();
         foreach ($rawRoleAssignments?->getHash() ?? [] as $row) {
-            $workspaceRoleAssignments = $workspaceRoleAssignments->add(WorkspaceRoleAssignment::create(
+            $workspaceRoleAssignments = $workspaceRoleAssignments->withAssignment(WorkspaceRoleAssignment::create(
                 WorkspaceRoleSubject::create(
                     WorkspaceRoleSubjectType::from($row['Type']),
                     $row['Value']