BUGFIX: Asset that SetNodeProperties is not handled empty

neos · Dec 5, 2024 · 455e12f · 455e12f
1 parent 2d735b2
commit 455e12f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/Neos.ContentRepository.Core/Classes/Feature/NodeModification/Command/SetNodeProperties.php b/Neos.ContentRepository.Core/Classes/Feature/NodeModification/Command/SetNodeProperties.php
@@ -48,6 +48,9 @@ private function __construct(
         public OriginDimensionSpacePoint $originDimensionSpacePoint,
         public PropertyValuesToWrite $propertyValues,
     ) {
+        if ($this->propertyValues->isEmpty()) {
+            throw new \InvalidArgumentException(sprintf('The command "SetNodeProperties" for node %s must contain property values', $this->nodeAggregateId->value), 1733394351);
+        }
     }
 
     /**

diff --git a/Neos.ContentRepository.Core/Classes/Feature/NodeModification/Dto/PropertyValuesToWrite.php b/Neos.ContentRepository.Core/Classes/Feature/NodeModification/Dto/PropertyValuesToWrite.php
@@ -95,4 +95,9 @@ public function getPropertiesToUnset(): PropertyNames
             )
         );
     }
+
+    public function isEmpty(): bool
+    {
+        return $this->values === [];
+    }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -95,4 +95,9 @@ public function getPropertiesToUnset(): PropertyNames @@
                 )
             );
         }
+        public function isEmpty(): bool
+        {
+            return $this->values === [];
+        }
     }