Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Reindex renderables on remove #151

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

reflexxion
Copy link
Contributor

Removing a renderable should set index of renderables as move does

Fixes #150

Removing a renderable should set index of renderables as move does

Fixes neos#150
Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot of sense to me and it even contains a corresponding issue and a test <3
+1 by reading

@daniellienert daniellienert merged commit ed43392 into neos:master Mar 25, 2022
@reflexxion reflexxion deleted the fix/renderable-order branch March 25, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

removeRenderable does not set new index
3 participants