Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: RuntimeSequenceHttpRequestHandler::$httpRequest must not be accessed before initialization #3454

Conversation

mhsdesign
Copy link
Member

if in testing context the throwable storage is invoked the default $requestInformationRenderer will cause getHttpRequest to be called

Now there is a null check, but its useless with php strict defined properties:

Typed property Neos\Flow\Testing\RequestHandler\RuntimeSequenceHttpRequestHandler::$httpRequest must not be accessed before initialization

Either we must use isset or default initialise the value to null

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

…ccessed before initialization

if in testing context the throwable storage is invoked the default  $requestInformationRenderer will cause `getHttpRequest` to be called

Now there is a null check, but its useless with php strict defined properties:

Typed property Neos\Flow\Testing\RequestHandler\RuntimeSequenceHttpRequestHandler::$httpRequest must not be accessed before initialization

Either we must use `isset` or default initialise the value to `null`
@kitsunet kitsunet merged commit a596411 into neos:9.0 Mar 11, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants