BUGFIX: RuntimeSequenceHttpRequestHandler::$httpRequest must not be accessed before initialization #3454
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if in testing context the throwable storage is invoked the default $requestInformationRenderer will cause
getHttpRequest
to be calledNow there is a null check, but its useless with php strict defined properties:
Typed property Neos\Flow\Testing\RequestHandler\RuntimeSequenceHttpRequestHandler::$httpRequest must not be accessed before initialization
Either we must use
isset
or default initialise the value tonull
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions