TASK: resource:clean followup #1678
#3275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While reading the code, looking for improvement, it seems tedious that we `getIdentifierByObject` just to `findByIdentifier` a few lines later. This happened due to a funny history of back and forth. At first - 2014 - `resource:clean` was introduced looping over the PersistentResource - neos@8a1ce0f Then - 2016 - it was decided to save the sha1 and loop over them and retrieve the asset via `findOneBySha1` But that did not improve the situation as described in neos#1678 and was removed again - 2019. So in functionality we made a full round, im just here to followup on the last fix to restore the full state syntactically as it was once though of.
mhsdesign
force-pushed
the
task/resourceCleanFollowup1678
branch
from
1b03888 to
dd6fbe0
Compare
There were three ways to answer > Do you want to remove all broken resource objects and related assets from the database? (y/n/c) But n(o) and c(ancel) both endet the script. To simplify things only y/n will be accepted answers.
bwaidelich
reviewed
Mar 5, 2024
mhsdesign
commented
Mar 5, 2024
Comment on lines
-278
to
-279
| while (!in_array($response, ['y', 'n', 'c'])) { | ||
| $response = $this->output->ask('<comment>Do you want to remove all broken resource objects and related assets from the database? (y/n/c) </comment>'); |
There was a problem hiding this comment.
it seems the cancel option was meant to be a hard stop while n would ask for each image.
This was NEVER implement that way not even for the first draft robert did. Thats why i removed cancel as its equivalent to no.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading the code, looking for improvement, it seems tedious that we
getIdentifierByObjectjust tofindByIdentifiera few lines later.This happened due to a funny history of back and forth.
At first - 2014 -
resource:cleanwas introduced looping over the PersistentResource: 8a1ce0fThen - 2016 - it was decided to save the sha1 and loop over them and retrieve the asset via
findOneBySha1: 879fba1But that did not improve the situation as described in #1678 and was removed again - 2019.
So in functionality we made a full round, im just here to followup on the last fix to restore the full state syntactically as it was once though of.