BUGFIX: Fix race-condition when initializing I18n Service #3188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation was an example of a check-then-act race-condition: There is no guarantee that the cached value still exists when it is subsequently read out. This would cause errors later when `$this->localCollection` could suddenly have the value `false`.
mhsdesign
force-pushed
the
bugfix/cached-collection-race-condition
branch
from
b82054f to
6f9716e
Compare
kitsunet
approved these changes
Mar 6, 2024
|
@kitsunet Any chance of getting this merged? Anything I can help with? |
markusguenther
approved these changes
Jan 15, 2025
christianharrington
deleted the
bugfix/cached-collection-race-condition
branch
|
Oops! I made a mistake and need to undo the change. I forgot to run the unit tests locally, and they failed because of that change. So, we need to fix that first before we can move forward. Tak for din contribution @christianharrington ❤️ |
Should I open a new PR @markusguenther? |
|
That would be very kind :) |
6 tasks
|
@markusguenther Done so here :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed in our error logs that we had quite a few errors being thrown from here:
My best guess is that this is due to a race-condition when the service is called for the first time on a host by multiple requests simultaneously.
In general, the pattern of first checking if some value is in the cache, and then reading the value out afterwards without checking it is never safe, as a different process/thread could have removed it.
The safe way is to read the value out once, and verify that it is set correctly (e.g. it should not
=== false).I think there's a few other places that follow the same unsafe pattern, but I suggest that they are addresses separately from this PR.
I haven't added any tests for this case, but please let me know if you have any ideas of how to test this.
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions