Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Relax psr cache constraints #2805

Merged
merged 2 commits into from
Mar 30, 2022
Merged

TASK: Relax psr cache constraints #2805

merged 2 commits into from
Mar 30, 2022

Conversation

kdambekalns
Copy link
Member

Fixes #2804

@kdambekalns kdambekalns requested review from mficzel and albe March 30, 2022 16:23
@kdambekalns kdambekalns self-assigned this Mar 30, 2022
@kdambekalns
Copy link
Member Author

I checked, and yes, one can provide multiple versions of something…

mficzel
mficzel approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@mficzel mficzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by reading. If the tests get green (especially with deps lowest) everything is fine.

@albe
Copy link
Member

albe commented Mar 30, 2022

Fine by reading. If the tests get green (especially with deps lowest) everything is fine.

Talking of which, where has the lowest deps build gone to?!

@mficzel
Copy link
Member

mficzel commented Mar 30, 2022

@albe wonder aswell, there has been one if remember correctly

@albe
Copy link
Member

albe commented Mar 30, 2022 •
edited
Loading

See #2806

And I also approved the PR that removed it. So yeah... owngoal :D

@mficzel mficzel force-pushed the task/relax-psr-cache-constraints branch from a3c9fc6 to 9642285 Compare March 30, 2022 18:20
@kdambekalns
Copy link
Member Author

Ok, this time with a lowest-dependencies check. 🤞

@kdambekalns kdambekalns merged commit c6b55de into neos:8.0 Mar 30, 2022
@kdambekalns kdambekalns deleted the task/relax-psr-cache-constraints branch March 31, 2022 08:11
@albe albe mentioned this pull request Apr 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albe albe albe approved these changes

@mficzel mficzel Awaiting requested review from mficzel

@jonnitto jonnitto Awaiting requested review from jonnitto

@kitsunet kitsunet Awaiting requested review from kitsunet

Assignees

@kdambekalns kdambekalns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdambekalns @albe @mficzel