-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
!!!TASK: Remove support for Flow's custom class loader #2775
!!!TASK: Remove support for Flow's custom class loader #2775
Conversation
This drops support for the Flow ClassLoader – except for functional testing. There it's still used to load test classes & fixtures.
Getting the tests to run without the class loader would be awesome, too… |
See also #2771 - I think we can get rid of the testing case if we manage to add autoload-dev section to the root composer manifest in the dev-distribution |
@albe that is not so easy as this would be required in all projects that use our unit tests as base. The clean way would be to extract the testcase base classes into seperate package that is dev-dependency. That way the tests for each package could be executed without depending on other packages tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one causes an error in Neos that should be addressed. Do not get yet why that happens exactly.
Required class "Neos\CliSetup\Command\SetupCommandController" could not be loaded properly for reflection from "Neos\CliSetup\Command\SetupCommandController".
The error may be a good sign and even correct.
But how would that make autoloading for |
Maybe this will solve this problem neos/neos-development-collection#3680 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this change things broke that should not have worked in the first place. Fine by testing but not fully understanding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine as is, let's tackle the bigger fish for next major
This drops support for the Flow ClassLoader – except for functional
testing. There it's still used to load test classes & fixtures.
If you still used the
FLOW_ONLY_COMPOSER_LOADER
environment variable to fallback to the old Flow autoloader, you need to update your package to use proper composer autoloading viaautoload
section.