Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Drop deprecated $packagePath from getFilteredPackages() #2774

Merged
merged 1 commit into from
Mar 26, 2022
Merged

TASK: Drop deprecated $packagePath from getFilteredPackages() #2774

merged 1 commit into from
Mar 26, 2022

Conversation

kdambekalns
Copy link
Member

No description provided.

@kdambekalns kdambekalns self-assigned this Mar 25, 2022
@kdambekalns kdambekalns mentioned this pull request Mar 25, 2022
Merged
mficzel
mficzel requested changes Mar 26, 2022
View reviewed changes
Copy link
Member

@mficzel mficzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is dangerous unless Neos is migrated at the same time. The SiteController uses the method and needs adjustments.

@kdambekalns
Copy link
Member Author

This is dangerous unless Neos is migrated at the same time. The SiteController uses the method and needs adjustments.

Yep, as already linked above: neos/neos-development-collection#3671

@mficzel mficzel merged commit c915358 into neos:master Mar 26, 2022
@kdambekalns kdambekalns deleted the task/drop-deprecated-packagePath branch March 27, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mficzel mficzel mficzel approved these changes

@jonnitto jonnitto jonnitto approved these changes

Assignees

@kdambekalns kdambekalns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdambekalns @mficzel @jonnitto