-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Extend DenormalizingObjectConverter to support fromBoolean and fromInteger #2766
FEATURE: Extend DenormalizingObjectConverter to support fromBoolean and fromInteger #2766
Conversation
…)` and `fromInteger()` ...in addition to their short version (`fromBool()` and `fromInt()`). This also adds a short documentation about Value Object property mapping. Related: #2763
[ci skip] [skip ci]
Apply fixes from StyleCI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by reading, huge thanks for the documentation fragment
@bwaidelich the psalm issues should be addressed still |
Doh, I never really know what to do with those.. can anyone help here? |
Looking into it. Those messages always make sense in hindsight. |
Well, it makes sense, because method_exists($targetType, 'someString'); can only work if $targetType::fromBool($source); before (since even PhpStorm complains about that part). But, more importantly.. I don't know how to get rid of the message :) |
c1c6846
to
e2e67a3
Compare
Checking for class_exists convinced psalm. It is a bit redundant but i also agree that relying on the order methods are called ist also not great. |
Thanks a lot! |
❤️ |
...in addition to their short version (
fromBool()
andfromInt()
).This also adds a short documentation about Value Object property mapping.
Related: #2763