!!!TASK: Remove legacy fluid custom error view options and migrate to viewOptions
#2743
Conversation
Concerning:
`Neos.Flow.error.exceptionHandler.renderingGroups.{exampleGroup}.options`
remove the legacy way of passing
* templatePathAndFilename
* layoutRootPath
* partialRootPath
* format
to a fluid view.
neos#2742
mhsdesign
force-pushed
the
task/2742-remove-legacy-custom-error-view-options
branch
from
ec62bcc to
637999f
Compare
albe
changed the title
viewOptionsviewOptions
|
taken from pr body: How to test:(Make sure youre on flow only - or comment out the neos.neos error view settings or also use neos/neos-development-collection#3637) throw some of these at your favorite places and marvel at the great exceptions: throw new DatabaseException();
throw new TargetNotFoundException(); // provokes a 404@kdambekalns to be super honest - this has been missed to be deprecated for a long time so i deprecated it retroactive: #2731 what makes this ofc a super breaking change... |
Oh, well. Fine with me, it was "legacy", at least. Still, a core migration should be easy enough, as this change is for a rather specific part of the settings. I hope. 😇 |
|
@kdambekalns voila: #2748 |
|
Why a separate pr for the migration? |
|
@mficzel because everyone reviewed already ^^ .... hmm i could remove those also |
|
If you think a new review is required you can do so in this pr. As Karsten asked for changes I would like to see them in here |
related: neos#2742 automated way for: ``` options: - templatePathAndFilename: 'file' - layoutRootPath: 'path' - partialRootPath: 'path' - format: 'html' + viewOptions: + templatePathAndFilename: 'file' + layoutRootPaths: ['path'] + partialRootPaths: ['path'] ```
warn if if Neos.Flow.error.exceptionHandler.defaultRenderingOptions was used with legacy fluid view options moving these options globally to the 'viewOptions' subkey would lead to that every view (not only fluid) will get them applied and not supported options view errors will occur.
There was a problem hiding this comment.
Can confirm that the migration works for renderingGroups.xxx.options.
@kdambekalns can you take a second look at the migration before merging.
|
the neos part is merged now: |
resolves: #2742
Concerning the options of any custom error view:
removes with Flow8 the legacy way of passing these options to a fluid view:
(those were fluid only and not set via
$view->setOption($option, $value)but set withObjectAccess::setPropertydirectly on the view instance. link)!!! Breaking
array{ viewClassName: string, viewOptions: array, renderTechnicalDetails: bool, logException: bool, variables?: array, - templatePathAndFilename?: string, - layoutRootPath?: string, - partialRootPath?: string, - format?: string }one is advised to migrate those settings manually to the equivalent option in the subkey
viewOptionsor use the Flow migrationNeos.Flow-20220318174300