BUGFIX: Eel Helper Array.push() auto cast string to array. #2710
#2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
im also fine when this should be merged as a feature in master, but its a nice to have utility |
mhsdesign
commented
Mar 18, 2022
jonnitto
reviewed
Mar 18, 2022
jonnitto
approved these changes
Mar 18, 2022
albe
approved these changes
Mar 18, 2022
mhsdesign
force-pushed
the
bugfix/typecast-in-array-push-2710
branch
from
d8c3ade to
fd79f26
Compare
|
so this can be merged then as 'Bugfix' ? |
mhsdesign
force-pushed
the
bugfix/typecast-in-array-push-2710
branch
from
fd79f26 to
5ab93ff
Compare
same lose behaviour exists already for `Array.concat()`
mhsdesign
force-pushed
the
bugfix/typecast-in-array-push-2710
branch
from
5ab93ff to
97d1588
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2710
same lose behaviour exists already for
Array.concat()