Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Don't use transactions to change db character set #2725

Merged
merged 5 commits into from
Mar 25, 2022
Merged

BUGFIX: Don't use transactions to change db character set #2725

merged 5 commits into from
Mar 25, 2022

Conversation

bwaidelich
Copy link
Member

Fixes: #2724

@bwaidelich
Copy link
Member Author

Note: I didn't test this!

kdambekalns
kdambekalns approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, makes sense. Obviously this code is older than my knowledge about MySQL not being transactional with DML statements… 🤷‍♂️

@kdambekalns kdambekalns enabled auto-merge March 15, 2022 18:19
@albe
Copy link
Member

albe commented Mar 25, 2022

Yup, makes sense. Obviously this code is older than my knowledge about MySQL not being transactional with DML statements… 🤷‍♂️

Yeah, that was something to chew on a year or so ago for me as well :D

@kdambekalns kdambekalns merged commit af3406e into 6.3 Mar 25, 2022
@kdambekalns kdambekalns deleted the bugfix/2724-avoid-transactions-in-convertToCharacterSetAndCollation branch March 25, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdambekalns kdambekalns kdambekalns approved these changes

@albe albe albe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwaidelich @albe @kdambekalns