FEATURE: Implement flushByTags for the PDO cache backend
#2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still a draft, as I want to check out if we can combine the SELECT with the first DELETE query by using a JOIN as hinted by @bwaidelich |
DELETE c FROM cache c JOIN tags t ON t.identifier = c.identifier WHERE t.tag IN ('tag1', 'tag2');should work |
|
@bwaidelich can't get it to work. Always get syntax error with the JOIN even though the same query works when directly executed in MySQL 😕 |
|
@Sebobo can you share your WIP? |
|
I tried various combinations of aliases etc., maybe its easier via screen share. I'll ping you. |
With this change the `flushByTags` is optimised to run in batches. The maximum batch size can and should be configured based on the used data source. This change relies on the interface changes in neos#2717
Sebobo
force-pushed
the
feature/flush-by-tags-pdo-backend
branch
from
220a2c3 to
1aeccfd
Compare
kdambekalns
approved these changes
Mar 23, 2022
robertlemke
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
With this change the
flushByTagsis optimised to run in batches.The maximum batch size can and should be configured based on the used data source.
This change relies on the interface changes in #2718
How I did it
Instead of querying identifiers for each tag separately, they are now queried in batches
for a number of tags and then deleted.
How to verify it
Configure PDO backend for the Neos content cache and force a flush by publishing something.
Checklist