-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make adjustments to support PHP8.1's stricter type system #2695
Conversation
It would be great to add php 8.1 to the test matrix in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good by reading, but I agree having 8.1 builds run would be good
8.1 builds are configured and run through smoothly, which leaves me a bit sceptical since that seems improbable. Is there more to be configured or is everything fine already? |
Looks good to me. Are there any specific reasons why you think running Flow on 8.1 should not work with this PR applied @nezaniel ? Are there any breaking changes in 8.1 that we should be subject to? |
i somehow miss the psalm test in the matrix now. Should offcourse not run on 7.3 but on 8.0 i think. Or was it disabled for not behaving well. |
@albe Well, I had to un-proxy literally every ESCR exception class for it to not throw a __wakeup() signature notice, so I expected this to happen all over the Flow code base... but maybe the ESCR test setup is a little more strict than the regular tests and PHP runtimes As far as I could see, the psalm tests were configured for 7.3 only, so I disabled them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good in general, I just added to nitpicky comments
Neos.Flow/Tests/Behavior/Features/Bootstrap/SecurityOperationsTrait.php
Outdated
Show resolved
Hide resolved
…Trait.php Co-authored-by: Bastian Waidelich <bastian@neos.io>
This adds additional type hints where required in PHP 8.1 while maintaining support for 7.4.
These are only the adjustments required fir the ESCR test suite, more are to follow
Resolves: #2698