BUGFIX: Wrong port assigned in applyTo()

[kdambekalns]

This fixes the following:

• given an HTTPS connection to a proxy that passes the request handling to a server via HTTP
• given a shortcut node pointing to http://www.acme.com
• will result in http://www.acme.com:443 leading to errors

This fixes it by using the (at this point already set!) scheme of the $uri to fill in the standard
port.

[kdambekalns]

Let's see if any test fails now… 😎

[kdambekalns]

Ok, question… How on earth does that expectation make any sense?

1) Neos\Flow\Tests\Unit\Mvc\Routing\Dto\UriConstraintsTest::applyToTests with data set #1 (array('https'), 'http://some-domain.tld', false, 'https://some-domain.tld:80/')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'https://some-domain.tld:80/'
+'https://some-domain.tld/'

/home/runner/work/flow-development-collection/flow-development-collection/flow-development-distribution/Packages/Framework/Neos.Flow/Tests/Unit/Mvc/Routing/Dto/UriConstraintsTest.php:101

I mean, if I really want to talk HTTPS to port 80, I better pass in the port explicitly. No?

[kdambekalns]

For me that second dataset should be

[
  'constraints' => [UriConstraints::CONSTRAINT_SCHEME => 'https'],
  'templateUri' => 'http://some-domain.tld',
  'forceAbsoluteUri' => false,
  'expectedUri' => 'https://some-domain.tld/'
]

or (in case we really want the "weird combo")

[
  'constraints' => [UriConstraints::CONSTRAINT_SCHEME => 'https', UriConstraints::CONSTRAINT_PORT => 80],
  'templateUri' => 'http://some-domain.tld',
  'forceAbsoluteUri' => false,
  'expectedUri' => 'https://some-domain.tld/'
]

[albe]

Hm, somehow makes sense...

[bwaidelich]

Yes, that makes a lot of sense. Thanks for taking care!