BUGFIX: Fix PhpAnalyzer to support PHP 8

[gerdemann]

When running composer with PHP 8, the PhpAnalyzer did not work properly.

Fixes: #2639

Checklist

• Code follows the PSR-2 coding style
• Tests have been created, run and adjusted as needed
• The PR is created against the lowest maintained branch

[sorenmalling]

@kitsunet You gave a comment about this in Slack, will you give some more details on it here, and comment on, whether or not this is a possible fix to the issue described?

[kitsunet]

The issue in question is certainly easy enough to fix and fine by me to do so.

My concern is that we haven't tested these versions with PHP 8 at all and regardless if you define php 8 as platform requirement in your project our third party dependencies in older versions might not work well with php 8 (and won't upgrade due to the restrictions we set on them because of breaking changes). @albe did quite a lot in regards to PHP 8 and might say something about compatibility for those older versions.

[gerdemann]

I only run composer with PHP 8 on my local machine and the platform config says PHP 7:

"config": {
    "platform": {
        "php": "7.3"
    }
}

Flow also runs in the Docker container with PHP 7, so there should be no problems.

[sorenmalling]

@albe I've added you as a reviewer due to your work on PHP8 - can you perhaps say something about compatibility, this issue and corresponding PR? :)

[albe]

This is basically a backport of the change here https://github.com/neos/flow-development-collection/pull/2287/files#diff-1cd00214dc173a34516d6f0aa372b178fc74317426c648d9487e9a28e15c9963 and it should be fully backwards compatible (with the defined() checks). The PhpAnalyzer afais is only used for package scanning and cache flushing. So this should not cause an issue and I don't see a problem with targeting it lower. However, is this targeting 5.3 on purpose, since that is security-only?

[gerdemann]

I need it for a 5.3 project, but you're right, it's not a security fix 😅
I change the target tomorrow to 6.3.

[albe]

Yeah, okay for me :)

[mficzel]

Fine by reading