Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Finalize introduction of role and privilege metadata #2353

Merged
merged 3 commits into from
Dec 14, 2020

Conversation

bwaidelich
Copy link
Member

This builds upon the work started with #2166 and

  • Fixes the Policy schema
  • Adds label & description to the "magic" base roles
  • Adds CLI commands in order to make use of the metadata
    within Flow

Usage:

./flow security:listRoles --include-abstract
./flow security:describeRole Neos.Flow:Everybody

Related: #2162

This builds upon the work started with #2166 and

* Fixes the Policy schema
* Adds label & description to the "magic" base roles
* Adds CLI commands in order to make use of the metadata
  within Flow

Usage:

    ./flow security:listRoles --include-abstract
    ./flow security:describeRole Neos.Flow:Everybody

Related: #2162
Copy link
Member

@albe albe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good by reading, need to check the CLI commands but they look promising!

Copy link
Member

@daniellienert daniellienert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Thanks @bwaidelich.
Looks good by reading. Test follows

@bwaidelich
Copy link
Member Author

Thanks for the quick reviews. I just realized that the docs are outdated, too. I'll push a follow-up and merge this with your votes

@bwaidelich bwaidelich merged commit 23c1c4b into 7.0 Dec 14, 2020
@bwaidelich bwaidelich deleted the bugfix/2162-fix-policy-schema branch December 14, 2020 10:31
@daniellienert
Copy link
Member

Tested post-merge ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants