Skip to content

Commit

Permalink
Merge pull request #5066 from neos/task/removeReferencesToDeprecateNo…
Browse files Browse the repository at this point in the history
…deReadModelProperties

TASK: Remove references to deprecate node read model properties
  • Loading branch information
mhsdesign authored May 19, 2024
2 parents 612ced2 + 5f398b3 commit 8e5b846
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/Adjustment/DisallowedChildNodeAdjustment.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public function findAdjustmentsForNodeType(NodeTypeName $nodeTypeName): \Generat

$parentNode = $subgraph->findParentNode($nodeAggregate->nodeAggregateId);
$grandparentNode = $parentNode !== null
? $subgraph->findParentNode($parentNode->nodeAggregateId)
? $subgraph->findParentNode($parentNode->aggregateId)
: null;

$allowedByParent = true;
Expand Down
2 changes: 1 addition & 1 deletion src/Adjustment/PropertyAdjustment.php
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ private function publishNodePropertiesWereSet(
new NodePropertiesWereSet(
$node->workspaceName,
$node->subgraphIdentity->contentStreamId,
$node->nodeAggregateId,
$node->aggregateId,
$node->originDimensionSpacePoint,
$nodeAggregate->getCoverageByOccupant($node->originDimensionSpacePoint),
$serializedPropertyValues,
Expand Down
8 changes: 4 additions & 4 deletions src/Adjustment/TetheredNodeAdjustments.php
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,8 @@ function () use ($tetheredNodeAggregate) {
$actualTetheredChildNodes = [];
foreach ($childNodes as $childNode) {
if ($childNode->classification->isTethered()) {
assert($childNode->nodeName !== null); // it's tethered!
$actualTetheredChildNodes[$childNode->nodeName->value] = $childNode;
assert($childNode->name !== null); // it's tethered!
$actualTetheredChildNodes[$childNode->name->value] = $childNode;
}
}

Expand Down Expand Up @@ -224,14 +224,14 @@ private function reorderNodes(
foreach ($coverageByOrigin as $coveredDimensionSpacePoint) {
$succeedingSiblingsForCoverage[] = new InterdimensionalSibling(
$coveredDimensionSpacePoint,
$succeedingNode->nodeAggregateId
$succeedingNode->aggregateId
);
}

$events[] = new NodeAggregateWasMoved(
$workspaceName,
$contentStreamId,
$nodeToMove->nodeAggregateId,
$nodeToMove->aggregateId,
null,
new InterdimensionalSiblings(...$succeedingSiblingsForCoverage),
);
Expand Down

0 comments on commit 8e5b846

Please sign in to comment.